22059 - loading animation for loading business info. #46
Conversation
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-46-n5t92760.web.app |
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-46-n5t92760.web.app |
src/app.vue
Outdated
| class="animate-spin text-[50px] text-gray-700 absolute top-40 left-[50%]" | ||
| /> | ||
| <div v-if="dashboardIsLoading || appLoading"> | ||
| <BcrosLoadingIcon class="animate-spin text-6xl text-gray-700 absolute top-40 left-[50%]" /> |
There was a problem hiding this comment.
Do you think we could move this to the layout? That way it could include covering the business details header. I think it should work pretty good if we replace the 'appLoading' with your new 'trackUiLoadingStart/Stop' inside the onMounted in here. That way the business details would always get the cached business info too so it would only make the one call
There was a problem hiding this comment.
moved them to the layouts, and replaced main loading with track loading stuff.
src/stores/ui.ts
Outdated
| const trackUiLoadingStop = (trackerUuidDone: string) => { | ||
| const index = uiIsLoading.value.find(tracker => tracker === trackerUuidDone) | ||
| if (index !== -1) { | ||
| uiIsLoading.value.splice(index, 1) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we should use findIndex since find will return the value not the index.
There was a problem hiding this comment.
Thank you, this is great spot
cypress/e2e/initial-page-load.cy.ts
Outdated
| cy.visit(`/${businessIdentifier}`) | ||
|
|
||
| cy.get('[data-cy="loading-icon"]').should('be.visible').then(() => { | ||
| cy.wait(['@getBusinessInfo']) | ||
| cy.get('[data-cy="loading-icon"]').should('not.exist') |
There was a problem hiding this comment.
question: why do we just wait @getBusinessInfo? Do we need to wait for the other calls to be intercepted (like getTasks) before the loading icon disappears?
There was a problem hiding this comment.
No, mandatory one is to wait for 2nd load business call. Generally we could wait for others too, but the thing is there is ~5 sec wait anyways if it is not immediately available. And if it fails with timeout we should investigate why. So its not necessary here.
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-46-n5t92760.web.app |
*Issue:22059 *bcgov/entity#22059
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).