Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15601 Merge Legal Name branch into main branch #579

Draft
wants to merge 99 commits into
base: main
Choose a base branch
from

Commits on Oct 10, 2023

  1. 15601 Legal Name changes (#575)

    * - app version = 5.6.0
    
    * - updated Legal API URL (temporary)
    - save operating name from business info
    - added operating name to state
    - added alternate names array to business inteface
    - added operating name store getter and setter
    - initialized operating name in state
    
    * - added temp API URL to example env file
    - added temp API URL to vaults env file
    - fixed misc code issues
    - changed DocumentMixin hook from created() to beforeCreate() to avoid type conflict
    - updated getBusinessLegalName to return operating name for firms
    
    * - updated EntityInfo unit tests
    
    * - added ids to some AssociationDetails elements
    - added AssociationDetails unit tests
    
    * - updated App unit tests
    
    * - deleted obsolete nginx config
    - updated firebase config to allow connecting to Legal API temp URL
    
    * - commented out invalid comment in Dockerfil
    
    * - renamed jest-wrapper-factory -> vitest-wrapper-factory
    
    * - reverted Dockerfile
    - restored nginx config
    severinbeauvais authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4c1dbb5 View commit details
    Browse the repository at this point in the history
  2. Update store.ts

    - added fallback in case firm operating name is empty
    severinbeauvais authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    54373b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    3fc7cca View commit details
    Browse the repository at this point in the history
  2. Update github action.

    pwei1018 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    207c90e View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. 19034 Rebasing legal name feature branch (#637)

    * 18102 (#576)
    
    Signed-off-by: Hongjing Chen <[email protected]>
    
    * Fixed Dissolution Date bug (#577)
    
    * Fixed dissolution date bug
    
    * Updated in response to Sev's comments + added unit tests
    
    * Fixed unit test
    
    * fixed unit test running locally but not with github ci
    
    * Added test case + fixed test
    
    * Added another test case
    
    * another small fix
    
    * trying something out
    
    * Added a test line
    
    * 17160 Update fetchNr with phone and email validation (#578)
    
    * update fetchNr with phone and email validation
    
    * fix small
    
    * replace fetch NR func
    
    * remove old fetch func
    
    * 18536 Fixed lint warnings before further development (#581)
    
    * - app version = 5.6.0
    - fixed a whack of lint warnings
    
    * - imported CorpTypeCd directly from module to avoid type confusion
    
    * 18449 - GP/SP registration modify (#582)
    
    * GP/SP regirstration modify
    
    * package version
    
    * fix linting
    
    * unit tests
    
    * clean up
    
    * fix linting
    
    * unit tests fix
    
    * unit tests fixing 2
    
    * fix linting
    
    * reset back to previous one
    
    * show old UI with registries staff only
    
    * GP/SP regirstration modify
    
    * fix linting
    
    * unit tests
    
    * clean up
    
    * unit tests fix
    
    * unit tests fixing 2
    
    * fix UI and testing
    
    * fix registries contact info messed up issue
    
    * fix lint
    
    * clean up help contact us
    
    * clean up the getter, import etc..
    
    * revert FirmContactInfo back
    
    * remove obsolete component
    
    * - app version = 5.6.2 (#583)
    
    - imported latest shared enums
    - imported latest shared interfaces
    - imported latest shared mixins
    - added route names to enum
    - added views to enum
    - added filing interface
    - added resource interface
    - updated state interface
    - added amalgamation state interface
    - updated filing template mixin
    - added initial amalgamation resources
    - added amalgamation steps
    - added amalgamation routes
    - added/updated getters/actions to  store
    - updated state model
    - added initial amalgamation views
    
    - renamed some methods in App.vue
    - added amalgamations to App.vue
    - added amalgamations to Actions.vue
    - added amalgamations to EntityInfo.vue
    - added amalgamations to SaveErrorDialog.vue
    - added fallbacks to amalgamations in filing-template-mixin.ts
    - added amalgamations to BreadCrumbResource.ts
    - added amalgamations to legal-services.ts
    - added amalgamations to feature-flag-utils.ts
    - misc cleanup
    
    - initial updates to Business Info page
    - initial updates to Information page
    
    - added Expandable Help
    - added error return links
    - added amalg blocks to Summary Define Company
    - added misc placeholders for future components
    
    - moved SummaryDefineCompany to common folder
    - moved ListShareClass to common folder
    - moved ShareStructure to common folder
    
    - updated validity in Stepper
    
    * 18625 Fix validate nr func (#584)
    
    * fix validate nr func
    
    * update version
    
    * 18535 - Add Amalgamating Businesses Part 1 (#585)
    
    * 18535 - Add Amalgamating Businesses Part 1
    
    * Fixed id name
    
    * Cleanup + added fix for new note
    
    * First set of fixes in response to Sev's comments
    
    * fixed lint error
    
    * Part fix in response to Sev's comments
    
    * 18640 Amalgamating business table (initial) (#586)
    
    * - app version = 5.6.5
    - added global warning (orange) colour
    - removed unnecessary re-export
    - added initial BusinessTable component
    - added initial validation code
    - added Business Status sub-component
    - added basic functionality to table
    - added Business Statuses enum
    - renamed property in amalg filing interface
    - updated filing save/restore
    - added businesses table to store (plus default initial state for now only)
    
    * wip
    
    * 18640 Amalgamating businesses structure + validations + etc (#587)
    
    * - app version = 5.6.6
    - worked on amalgamating businesses data/types
    - renamed some enums
    - fixed table key
    - added more BusinessTable logic (including foreign jurisdiction)
    - updated static (test) data
    - updated some imports in unit tests
    
    * - misc fixes
    
    * 18640 More amalgamating business table work (#589)
    
    * - app version = 5.6.7
    
    * - changed break to return in App.vue
    - always import CorpTypeCd from corp-type-module (never enums)
    - added some TING business rules
    - removed status from static data
    
    * - more table logic
    - more test data cleanup
    
    * wip
    
    * wip
    
    * - deleted unneeded getters, etc
    - added Business Table Summary
    
    * wip
    
    * wip
    
    * 18535 Amalgamating Businesses Part 1 Continuation (#588)
    
    * Refactored saveAmalgamatingBusiness + specified what to search for
    
    * Setup AmalgamatingBusinesses validity
    
    * fixed unit tests
    
    * cleanup
    
    * Populate the table using the business lookup
    
    * Fixed in response to Sev's comments
    
    * Small cleanup in response to Sev's comment
    
    * updated package version
    
    * 18535 - Save and Resume Draft Amalgamation (#592)
    
    * Save and resume draft amalgamation
    
    * Properly initialize array if continuing a draft
    
    * updated package version
    
    * 18538 Resulting Business Name and Type component (WIP) (#591)
    
    * PR (TODO fix unit tests)
    
    * Added unit tests for numbered am
    
    * Fixed test case and update from comments
    
    * Added additional test case
    
    * Updated unit test formatting.
    
    * Updated package.json
    
    * Added bullet points for numberd AML
    
    * Fixed test cases
    
    * 18640 Incremental amalgamating businesses validations, etc (#590)
    
    * - app version = 5.6.10
    - updated some validity calculations
    - moved ting validations to a mixin
    - generalized status computation
    - updated regular amalgation validity
    
    * - updated to use temp copy of array (instead of local copy)
    
    * wip
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 18640 More amalgamating fetch / validations work (#593)
    
    * - app version = 5.6.11
    - imported latest BusinessLookup shared component
    - updated fetchBusinessInfo return object
    - simplified Amalg Businesses button and panel logic
    - added Cancel button to Foreign panel
    - added snackbar for save business errors
    - deleted debugging template code
    
    * - added fetch for business filings (for more validations)
    - renamed AmalgamatingStatuses -> AmlStatuses
    - added AmlTypes enum and replaced strings
    - added some properties to TING business object (for more validations)
    - added LegalServices.fetchFilings()
    - misc updates
    
    * - changed all to allSettled so I can get partial fetches
    - fall back to lookup properties if some fetches fail (eg, not amalgamated)
    - added empty table message
    - temporarily start with empty (instead of pre-populated) table
    
    * wip
    
    * wip
    
    * - logic cleanup
    
    * - added proper check for limited restoration
    - now fetch only first filing (to check for FED)
    - fixed fetchFirstOrOnlyFiling() (for use with array response)
    
    * - fixed unit test
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 18971 Finished some TODOs and incremental work on amalgamating business validations (#596)
    
    * - app version = 5.6.12
    - finished stepper validity code
    - cleaned up some store code
    - misc cleanup
    - named and sorted rules
    
    * - added spinner (experimental)
    
    * wip
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 18960 - Re-fetch businesses information when loading draft (#594)
    
    * Refactored the code + centralized fetch calls
    
    * fixed lint errors
    
    * Rebased + fixed rebase issues + fixed some of Sev's comments
    
    * 18722 Add ForeignBusiness component for amalgamating businesses (#595)
    
    * Add ForeignBusiness component
    
    * Fix rebase issues
    
    * Update nested select value
    
    * Fix lint error
    
    * Add spaces between tags
    
    * Move foreign business component code to parent
    
    * Wrap btn text in span
    
    * Use common jurisdiction component
    
    * 18971 Updated TING validations (#597)
    
    * - app version = 5.6.13
    - added dotted underline class that works for multiple lines
    - cleaned up BusinessStatus and changed tooltip activator
    - added tooltip text cases
    - added validation rules and getters (still WIP)
    - moved static businesses code from state-model to filing-template-mixin
    
    * - on app start, display app name and version
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * Update foreign company error messages (#599)
    
    * 18788 Updated amalgamation -> amalgamationApplication + business name options (WIP) (#598)
    
    * - app version = 5.6.14
    - added ResultingBusinessName component
    - misc refactor and new code to handle 3 options
    - still WIP
    
    * - changed snackbar close text to a white icon
    
    * - added random key to BusinessLookup to reset its state between calls
    
    * - replaced local EntityState with shared EntityStates
    - added validation for isHistorical
    
    * - ResultingBusinessName WIP !!!
    
    * - updated imported enums, etc
    - updated some enums locally (amalgamation -> amalgamationApplication)
    - ResultingBusinessName is still WIP (so don't use it)
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 18546 - add Folio Number to Review and Confirm step (#601)
    
    * 18546-add folio number component
    
    * 18546-validaions for folio number and unit test
    
    * 18546-step validations
    
    * 18546-fix spacing and change getter name
    
    * 18546-update comments
    
    * 18546-remove unused getter
    
    * 18546-update package version
    
    * 18546-premium account, label changes
    
    * 18546-premium account check for validation
    
    * 18847-update certify text for amalgamations (#603)
    
    * 18722 - Update foreign business validation rules (#602)
    
    * Update mras corp number rules
    
    * Add test code
    
    * Fix foreign jurisdiction validations
    
    * Corp Number only required if Mras
    
    * Update validation on jurisdiction change
    
    * Update isForeignBusinessValid
    
    * Fix typo
    
    * Use common Mras list
    
    * Add comments to foreign business validation
    
    * Update != to !==
    
    * Update version to 5.6.17
    
    * 18848 - add court order / POA component on review page (#604)
    
    * 18848-add Court order on review page
    
    * 18848-update package version
    
    * - app version = 5.6.19 (#600)
    
    - imported updated shared correct-name and mixins
    - updated some validations
    - updated misc whitespace
    - added additional options to ResultingBusinessName.vue
    - added additional option to NameRequestInfo.vue
    - fixed numbered company suffix
    - added conditional links to return to proper steps
    - updated save/resume name options
    - updated more validations
    - temporarily skipped some unit tests
    - misc cleanup
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 19019 Add extra-pro A TING companies (#605)
    
    * Add extra-pro TING companies
    
    * Updated in response to Sev's comments
    
    * updated package version after rebasing
    
    * Fixed in response to Sev's comments
    
    * fixed name
    
    * removed unneeded comment
    
    * extra empty line
    
    * - app version = 5.6.21 (#606)
    
    - added fallback for drafts created without Correct Name Option
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.6.22 (#607)
    
    - updated base class to remove border radius (per UI designs)
    - added message box to step 5
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.6.23 (#610)
    
    - fixed amalgamation information title
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.6.24 (#611)
    
    - reordered sections so amalgamations don't use generic section
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * fix unit test (#612)
    
    Merging without updating app version since it's only a unit test change.
    
    * 18749 - add amalgamation statement to review (#609)
    
    * ui parts
    
    * able to store, valid, and update
    
    * update version
    
    * ui parts
    
    * able to store, valid, and update
    
    * able to save
    
    * still working on adding test file, fix other comments
    
    * package conflict
    
    * add unit text file
    
    * lint and version
    
    * add comments
    
    * JSDoc syntax
    
    * Final Framework Changes/Fixes for Regular Amalgamation (#608)
    
    * Added unit tests for amalgamation views + lots of misc. fixes and cleanup
    
    * Added test line for review and confirm page
    
    * More and more fixes + cleanup
    
    * Added return to step for business summary table
    
    * Fixed in response to Sev's comments
    
    * updated comment
    
    * Fixed Amalgamation Statement test after rebase + updated package version
    
    * 18749 - fix bug in reopen draft amalgamation file (#613)
    
    * update version
    
    * add validation to mounted function
    
    * update version
    
    * - app version = 5.6.28 (#615)
    
    - misc fixes
    - added Business Status unit tests
    - added Business Table unit tests
    - added Business Table Summary unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 18689 More Amalgamation fixes/updates (#614)
    
    * Fixed Review and Confirm page validation
    
    * Re-fetch business table data on file and pay
    
    * updated package version
    
    * removed debug code
    
    * Fixed re-fetching issue
    
    * add account id header (#616)
    
    * Fixed bug with certify if submitting the amalgamation failed (#617)
    
    * 18641 More unit tests (#618)
    
    * - app version = 5.6.32
    - added Amalgamation Mixin unit tests
    - updated some status messages (per Yui)
    - updated some rules (per Yui)
    - added more Business Table unit tests (disabled until future)
    - misc updates
    
    * - added missing rule to list
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.6.33 (#619)
    
    - do not save numbered name
    - do not restore numbered name
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.6.34 (#620)
    
    - fixed check for future effective filing
    - added missing filing statuses to enum
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.6.35 (#621)
    
    - added check for pending dissolution filing
    - moved checks as new functions in mixin
    - added business status (message) for pending dissolution
    - added enum value
    - updated state interface
    - added new rule in mixin
    - misc clean and missing code
    - updated unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 19050 Changed pending dissolution check to pending filing check (#622)
    
    * - app version = 5.6.36
    - changed pending dissolution check to pending filing check
    
    * - updated tooltip message
    
    * - another tooltip message update
    
    * - changed companies from title case to lower case
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 19201+19275+19216 More Amalgamation Fixes (#623)
    
    * Lots and lots of amalgamation fixes
    
    * fixed rebase issue + updated package version
    
    * added unit test for frozen rule
    
    * fixed rebase issue
    
    * Fixed in response to Sev's comments
    
    * updated package version after rebase
    
    * Amalgamation stepper fix (#624)
    
    * Amalgamation stepper fix
    
    * Fixed spacing more after discussion with Yui
    
    * fixed icon size
    
    * - app version = 5.6.39 (#625)
    
    - disabled incorporator/organization code for amalgamations
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * 19179 Added Amalgamating Businesses unit tests (#626)
    
    * - app version = 5.6.40
    - added element ids
    - updated LEAR business duplicate check
    - added foreign business duplicate check
    - misc cleanup
    - added test suite (WIP)
    
    * wip
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.6.41 (#627)
    
    - added rest of unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.6.42 (#629)
    
    - added isDraftTask to Amalgamating Business interface
    - added business status tooltip for Draft Task error
    - added amalgamation enum value
    - added new test to amalgamation rules
    - added fetch of first task
    - added helper function to amalgamation mixin
    - updated / added unit tests
    - minor cleanup
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * Bump vite from 4.3.9 to 4.5.2 (#631)
    
    Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
    - [Release notes](https://github.com/vitejs/vite/releases)
    - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
    - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)
    
    ---
    updated-dependencies:
    - dependency-name: vite
      dependency-type: direct:development
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    
    * 19359 - Amalgamating Businesses Table must have more than 1 (#628)
    
    * Fixed amalgamating business length to be more than 1
    
    * Rebased + fixed Sev's comment + added unit tests
    
    * Fixed lint issues
    
    * removed unneeded nextTick in tests
    
    * 19040 Framework for short-form amalgamations (#630)
    
    * - app version = 5.7.0
    - updated App header/title
    - added short-form amalgamation re-routing
    - added short-form amalgamation resource loading
    - updated Steppersimplified
    - added short-form amalgamation return links, etc
    - added short-form amalgamation route names
    - delete unneeded data in regular amalgamation resources
    - added short-form amalgamation resources and steps
    - broke up routes in sub-files
    - added short-form amalgamation routes
    - updated some store getters
    - combined views for regular + short-form
    - added conditionals in views for differences
    - added some computeds to keep template simple
    - updated unit tests
    - fixed missing effective date validity check
    
    * - deleted unused incorporation agreement type
    
    * - added option for Primary (vs Holding) Company
    
    * - fixed unit tests
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * - app version = 5.7.1 (#634)
    
    - don't show Add Person for short-form amalgamation
    - set initial OfficeAddresses validity
    - deleted unneeded data from amalg IF
    - finished short amalg Office Addresses layout
    
    Co-authored-by: Severin Beauvais <[email protected]>
    
    * Implemented the Continuation In Framework (#633)
    
    * Implemented the Continuation In Framework
    
    * some fixes related to continuation in interfaces
    
    * Rebased + fix rebase issues + fixed in response to comments
    
    * Small fixes in response to Sev's comments
    
    * Fixed typo
    
    * updated package version
    
    * major upgrade to package.json
    
    ---------
    
    Signed-off-by: Hongjing Chen <[email protected]>
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: Hongjing <[email protected]>
    Co-authored-by: Kevin Zhang <[email protected]>
    Co-authored-by: Séverin Beauvais <[email protected]>
    Co-authored-by: Shaoyun Tong <[email protected]>
    Co-authored-by: jamespaologarcia <[email protected]>
    Co-authored-by: Severin Beauvais <[email protected]>
    Co-authored-by: leodube-aot <[email protected]>
    Co-authored-by: ketaki-deodhar <[email protected]>
    Co-authored-by: Vysakh Menon <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    11 people authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a5248f7 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    1b025b3 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. 18102 (#576)

    Signed-off-by: Hongjing Chen <[email protected]>
    chenhongjing authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a30d1d5 View commit details
    Browse the repository at this point in the history
  2. Fixed Dissolution Date bug (#577)

    * Fixed dissolution date bug
    
    * Updated in response to Sev's comments + added unit tests
    
    * Fixed unit test
    
    * fixed unit test running locally but not with github ci
    
    * Added test case + fixed test
    
    * Added another test case
    
    * another small fix
    
    * trying something out
    
    * Added a test line
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    718e3e4 View commit details
    Browse the repository at this point in the history
  3. 17160 Update fetchNr with phone and email validation (#578)

    * update fetchNr with phone and email validation
    
    * fix small
    
    * replace fetch NR func
    
    * remove old fetch func
    kzdev420 authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5945ff2 View commit details
    Browse the repository at this point in the history
  4. 18536 Fixed lint warnings before further development (#581)

    * - app version = 5.6.0
    - fixed a whack of lint warnings
    
    * - imported CorpTypeCd directly from module to avoid type confusion
    severinbeauvais authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a7a7113 View commit details
    Browse the repository at this point in the history
  5. 18449 - GP/SP registration modify (#582)

    * GP/SP regirstration modify
    
    * package version
    
    * fix linting
    
    * unit tests
    
    * clean up
    
    * fix linting
    
    * unit tests fix
    
    * unit tests fixing 2
    
    * fix linting
    
    * reset back to previous one
    
    * show old UI with registries staff only
    
    * GP/SP regirstration modify
    
    * fix linting
    
    * unit tests
    
    * clean up
    
    * unit tests fix
    
    * unit tests fixing 2
    
    * fix UI and testing
    
    * fix registries contact info messed up issue
    
    * fix lint
    
    * clean up help contact us
    
    * clean up the getter, import etc..
    
    * revert FirmContactInfo back
    
    * remove obsolete component
    tshyun24 authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1cf4634 View commit details
    Browse the repository at this point in the history
  6. - app version = 5.6.2 (#583)

    - imported latest shared enums
    - imported latest shared interfaces
    - imported latest shared mixins
    - added route names to enum
    - added views to enum
    - added filing interface
    - added resource interface
    - updated state interface
    - added amalgamation state interface
    - updated filing template mixin
    - added initial amalgamation resources
    - added amalgamation steps
    - added amalgamation routes
    - added/updated getters/actions to  store
    - updated state model
    - added initial amalgamation views
    
    - renamed some methods in App.vue
    - added amalgamations to App.vue
    - added amalgamations to Actions.vue
    - added amalgamations to EntityInfo.vue
    - added amalgamations to SaveErrorDialog.vue
    - added fallbacks to amalgamations in filing-template-mixin.ts
    - added amalgamations to BreadCrumbResource.ts
    - added amalgamations to legal-services.ts
    - added amalgamations to feature-flag-utils.ts
    - misc cleanup
    
    - initial updates to Business Info page
    - initial updates to Information page
    
    - added Expandable Help
    - added error return links
    - added amalg blocks to Summary Define Company
    - added misc placeholders for future components
    
    - moved SummaryDefineCompany to common folder
    - moved ListShareClass to common folder
    - moved ShareStructure to common folder
    
    - updated validity in Stepper
    severinbeauvais authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e269132 View commit details
    Browse the repository at this point in the history
  7. 18625 Fix validate nr func (#584)

    * fix validate nr func
    
    * update version
    kzdev420 authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    37dc844 View commit details
    Browse the repository at this point in the history
  8. 18535 - Add Amalgamating Businesses Part 1 (#585)

    * 18535 - Add Amalgamating Businesses Part 1
    
    * Fixed id name
    
    * Cleanup + added fix for new note
    
    * First set of fixes in response to Sev's comments
    
    * fixed lint error
    
    * Part fix in response to Sev's comments
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7aeb453 View commit details
    Browse the repository at this point in the history
  9. 18640 Amalgamating business table (initial) (#586)

    * - app version = 5.6.5
    - added global warning (orange) colour
    - removed unnecessary re-export
    - added initial BusinessTable component
    - added initial validation code
    - added Business Status sub-component
    - added basic functionality to table
    - added Business Statuses enum
    - renamed property in amalg filing interface
    - updated filing save/restore
    - added businesses table to store (plus default initial state for now only)
    
    * wip
    severinbeauvais authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9a29f58 View commit details
    Browse the repository at this point in the history
  10. 18640 Amalgamating businesses structure + validations + etc (#587)

    * - app version = 5.6.6
    - worked on amalgamating businesses data/types
    - renamed some enums
    - fixed table key
    - added more BusinessTable logic (including foreign jurisdiction)
    - updated static (test) data
    - updated some imports in unit tests
    
    * - misc fixes
    severinbeauvais authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f02baac View commit details
    Browse the repository at this point in the history
  11. 18640 More amalgamating business table work (#589)

    * - app version = 5.6.7
    
    * - changed break to return in App.vue
    - always import CorpTypeCd from corp-type-module (never enums)
    - added some TING business rules
    - removed status from static data
    
    * - more table logic
    - more test data cleanup
    
    * wip
    
    * wip
    
    * - deleted unneeded getters, etc
    - added Business Table Summary
    
    * wip
    
    * wip
    severinbeauvais authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    afa2a0e View commit details
    Browse the repository at this point in the history
  12. 18535 Amalgamating Businesses Part 1 Continuation (#588)

    * Refactored saveAmalgamatingBusiness + specified what to search for
    
    * Setup AmalgamatingBusinesses validity
    
    * fixed unit tests
    
    * cleanup
    
    * Populate the table using the business lookup
    
    * Fixed in response to Sev's comments
    
    * Small cleanup in response to Sev's comment
    
    * updated package version
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6122a37 View commit details
    Browse the repository at this point in the history
  13. 18535 - Save and Resume Draft Amalgamation (#592)

    * Save and resume draft amalgamation
    
    * Properly initialize array if continuing a draft
    
    * updated package version
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d949e22 View commit details
    Browse the repository at this point in the history
  14. 18538 Resulting Business Name and Type component (WIP) (#591)

    * PR (TODO fix unit tests)
    
    * Added unit tests for numbered am
    
    * Fixed test case and update from comments
    
    * Added additional test case
    
    * Updated unit test formatting.
    
    * Updated package.json
    
    * Added bullet points for numberd AML
    
    * Fixed test cases
    jamespaologarcia authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    21e1113 View commit details
    Browse the repository at this point in the history
  15. 18640 Incremental amalgamating businesses validations, etc (#590)

    * - app version = 5.6.10
    - updated some validity calculations
    - moved ting validations to a mixin
    - generalized status computation
    - updated regular amalgation validity
    
    * - updated to use temp copy of array (instead of local copy)
    
    * wip
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9e2fb3d View commit details
    Browse the repository at this point in the history
  16. 18640 More amalgamating fetch / validations work (#593)

    * - app version = 5.6.11
    - imported latest BusinessLookup shared component
    - updated fetchBusinessInfo return object
    - simplified Amalg Businesses button and panel logic
    - added Cancel button to Foreign panel
    - added snackbar for save business errors
    - deleted debugging template code
    
    * - added fetch for business filings (for more validations)
    - renamed AmalgamatingStatuses -> AmlStatuses
    - added AmlTypes enum and replaced strings
    - added some properties to TING business object (for more validations)
    - added LegalServices.fetchFilings()
    - misc updates
    
    * - changed all to allSettled so I can get partial fetches
    - fall back to lookup properties if some fetches fail (eg, not amalgamated)
    - added empty table message
    - temporarily start with empty (instead of pre-populated) table
    
    * wip
    
    * wip
    
    * - logic cleanup
    
    * - added proper check for limited restoration
    - now fetch only first filing (to check for FED)
    - fixed fetchFirstOrOnlyFiling() (for use with array response)
    
    * - fixed unit test
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    54186b9 View commit details
    Browse the repository at this point in the history
  17. 18971 Finished some TODOs and incremental work on amalgamating busine…

    …ss validations (#596)
    
    * - app version = 5.6.12
    - finished stepper validity code
    - cleaned up some store code
    - misc cleanup
    - named and sorted rules
    
    * - added spinner (experimental)
    
    * wip
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ee544d1 View commit details
    Browse the repository at this point in the history
  18. 18960 - Re-fetch businesses information when loading draft (#594)

    * Refactored the code + centralized fetch calls
    
    * fixed lint errors
    
    * Rebased + fixed rebase issues + fixed some of Sev's comments
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    54eb91e View commit details
    Browse the repository at this point in the history
  19. 18722 Add ForeignBusiness component for amalgamating businesses (#595)

    * Add ForeignBusiness component
    
    * Fix rebase issues
    
    * Update nested select value
    
    * Fix lint error
    
    * Add spaces between tags
    
    * Move foreign business component code to parent
    
    * Wrap btn text in span
    
    * Use common jurisdiction component
    leodube-aot authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    349f91d View commit details
    Browse the repository at this point in the history
  20. 18971 Updated TING validations (#597)

    * - app version = 5.6.13
    - added dotted underline class that works for multiple lines
    - cleaned up BusinessStatus and changed tooltip activator
    - added tooltip text cases
    - added validation rules and getters (still WIP)
    - moved static businesses code from state-model to filing-template-mixin
    
    * - on app start, display app name and version
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4e40583 View commit details
    Browse the repository at this point in the history
  21. 18788 Updated amalgamation -> amalgamationApplication + business name…

    … options (WIP) (#598)
    
    * - app version = 5.6.14
    - added ResultingBusinessName component
    - misc refactor and new code to handle 3 options
    - still WIP
    
    * - changed snackbar close text to a white icon
    
    * - added random key to BusinessLookup to reset its state between calls
    
    * - replaced local EntityState with shared EntityStates
    - added validation for isHistorical
    
    * - ResultingBusinessName WIP !!!
    
    * - updated imported enums, etc
    - updated some enums locally (amalgamation -> amalgamationApplication)
    - ResultingBusinessName is still WIP (so don't use it)
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c595237 View commit details
    Browse the repository at this point in the history
  22. 18546 - add Folio Number to Review and Confirm step (#601)

    * 18546-add folio number component
    
    * 18546-validaions for folio number and unit test
    
    * 18546-step validations
    
    * 18546-fix spacing and change getter name
    
    * 18546-update comments
    
    * 18546-remove unused getter
    
    * 18546-update package version
    
    * 18546-premium account, label changes
    
    * 18546-premium account check for validation
    ketaki-deodhar authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    08b1f7c View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    f60ee98 View commit details
    Browse the repository at this point in the history
  24. 18722 - Update foreign business validation rules (#602)

    * Update mras corp number rules
    
    * Add test code
    
    * Fix foreign jurisdiction validations
    
    * Corp Number only required if Mras
    
    * Update validation on jurisdiction change
    
    * Update isForeignBusinessValid
    
    * Fix typo
    
    * Use common Mras list
    
    * Add comments to foreign business validation
    
    * Update != to !==
    
    * Update version to 5.6.17
    leodube-aot authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    489023b View commit details
    Browse the repository at this point in the history
  25. 18848 - add court order / POA component on review page (#604)

    * 18848-add Court order on review page
    
    * 18848-update package version
    ketaki-deodhar authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    608997a View commit details
    Browse the repository at this point in the history
  26. - app version = 5.6.19 (#600)

    - imported updated shared correct-name and mixins
    - updated some validations
    - updated misc whitespace
    - added additional options to ResultingBusinessName.vue
    - added additional option to NameRequestInfo.vue
    - fixed numbered company suffix
    - added conditional links to return to proper steps
    - updated save/resume name options
    - updated more validations
    - temporarily skipped some unit tests
    - misc cleanup
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f7fde54 View commit details
    Browse the repository at this point in the history
  27. 19019 Add extra-pro A TING companies (#605)

    * Add extra-pro TING companies
    
    * Updated in response to Sev's comments
    
    * updated package version after rebasing
    
    * Fixed in response to Sev's comments
    
    * fixed name
    
    * removed unneeded comment
    
    * extra empty line
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    cab33e1 View commit details
    Browse the repository at this point in the history
  28. - app version = 5.6.21 (#606)

    - added fallback for drafts created without Correct Name Option
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e7e8c01 View commit details
    Browse the repository at this point in the history
  29. - app version = 5.6.22 (#607)

    - updated base class to remove border radius (per UI designs)
    - added message box to step 5
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1986435 View commit details
    Browse the repository at this point in the history
  30. - app version = 5.6.23 (#610)

    - fixed amalgamation information title
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    79d2c5e View commit details
    Browse the repository at this point in the history
  31. - app version = 5.6.24 (#611)

    - reordered sections so amalgamations don't use generic section
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    442831a View commit details
    Browse the repository at this point in the history
  32. fix unit test (#612)

    Merging without updating app version since it's only a unit test change.
    kzdev420 authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e1cbaa6 View commit details
    Browse the repository at this point in the history
  33. 18749 - add amalgamation statement to review (#609)

    * ui parts
    
    * able to store, valid, and update
    
    * update version
    
    * ui parts
    
    * able to store, valid, and update
    
    * able to save
    
    * still working on adding test file, fix other comments
    
    * package conflict
    
    * add unit text file
    
    * lint and version
    
    * add comments
    
    * JSDoc syntax
    tshyun24 authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e3d3d29 View commit details
    Browse the repository at this point in the history
  34. Final Framework Changes/Fixes for Regular Amalgamation (#608)

    * Added unit tests for amalgamation views + lots of misc. fixes and cleanup
    
    * Added test line for review and confirm page
    
    * More and more fixes + cleanup
    
    * Added return to step for business summary table
    
    * Fixed in response to Sev's comments
    
    * updated comment
    
    * Fixed Amalgamation Statement test after rebase + updated package version
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2dbc4cd View commit details
    Browse the repository at this point in the history
  35. 18749 - fix bug in reopen draft amalgamation file (#613)

    * update version
    
    * add validation to mounted function
    
    * update version
    tshyun24 authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    3e7c678 View commit details
    Browse the repository at this point in the history
  36. - app version = 5.6.28 (#615)

    - misc fixes
    - added Business Status unit tests
    - added Business Table unit tests
    - added Business Table Summary unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    86fd2d5 View commit details
    Browse the repository at this point in the history
  37. 18689 More Amalgamation fixes/updates (#614)

    * Fixed Review and Confirm page validation
    
    * Re-fetch business table data on file and pay
    
    * updated package version
    
    * removed debug code
    
    * Fixed re-fetching issue
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    be19f39 View commit details
    Browse the repository at this point in the history
  38. add account id header (#616)

    vysakh-menon-aot authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    afad241 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    3cac679 View commit details
    Browse the repository at this point in the history
  40. 18641 More unit tests (#618)

    * - app version = 5.6.32
    - added Amalgamation Mixin unit tests
    - updated some status messages (per Yui)
    - updated some rules (per Yui)
    - added more Business Table unit tests (disabled until future)
    - misc updates
    
    * - added missing rule to list
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a643e03 View commit details
    Browse the repository at this point in the history
  41. - app version = 5.6.33 (#619)

    - do not save numbered name
    - do not restore numbered name
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9638bc3 View commit details
    Browse the repository at this point in the history
  42. - app version = 5.6.34 (#620)

    - fixed check for future effective filing
    - added missing filing statuses to enum
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    98de533 View commit details
    Browse the repository at this point in the history
  43. - app version = 5.6.35 (#621)

    - added check for pending dissolution filing
    - moved checks as new functions in mixin
    - added business status (message) for pending dissolution
    - added enum value
    - updated state interface
    - added new rule in mixin
    - misc clean and missing code
    - updated unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    aa5d54d View commit details
    Browse the repository at this point in the history
  44. 19050 Changed pending dissolution check to pending filing check (#622)

    * - app version = 5.6.36
    - changed pending dissolution check to pending filing check
    
    * - updated tooltip message
    
    * - another tooltip message update
    
    * - changed companies from title case to lower case
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    de5e408 View commit details
    Browse the repository at this point in the history
  45. 19201+19275+19216 More Amalgamation Fixes (#623)

    * Lots and lots of amalgamation fixes
    
    * fixed rebase issue + updated package version
    
    * added unit test for frozen rule
    
    * fixed rebase issue
    
    * Fixed in response to Sev's comments
    
    * updated package version after rebase
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0076fae View commit details
    Browse the repository at this point in the history
  46. Amalgamation stepper fix (#624)

    * Amalgamation stepper fix
    
    * Fixed spacing more after discussion with Yui
    
    * fixed icon size
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9590666 View commit details
    Browse the repository at this point in the history
  47. - app version = 5.6.39 (#625)

    - disabled incorporator/organization code for amalgamations
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a1cae5c View commit details
    Browse the repository at this point in the history
  48. 19179 Added Amalgamating Businesses unit tests (#626)

    * - app version = 5.6.40
    - added element ids
    - updated LEAR business duplicate check
    - added foreign business duplicate check
    - misc cleanup
    - added test suite (WIP)
    
    * wip
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    be3e120 View commit details
    Browse the repository at this point in the history
  49. - app version = 5.6.41 (#627)

    - added rest of unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6412b0f View commit details
    Browse the repository at this point in the history
  50. - app version = 5.6.42 (#629)

    - added isDraftTask to Amalgamating Business interface
    - added business status tooltip for Draft Task error
    - added amalgamation enum value
    - added new test to amalgamation rules
    - added fetch of first task
    - added helper function to amalgamation mixin
    - updated / added unit tests
    - minor cleanup
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c3c9a0d View commit details
    Browse the repository at this point in the history
  51. Bump vite from 4.3.9 to 4.5.2 (#631)

    Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
    - [Release notes](https://github.com/vitejs/vite/releases)
    - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
    - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)
    
    ---
    updated-dependencies:
    - dependency-name: vite
      dependency-type: direct:development
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    34e838c View commit details
    Browse the repository at this point in the history
  52. 19359 - Amalgamating Businesses Table must have more than 1 (#628)

    * Fixed amalgamating business length to be more than 1
    
    * Rebased + fixed Sev's comment + added unit tests
    
    * Fixed lint issues
    
    * removed unneeded nextTick in tests
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    aca328c View commit details
    Browse the repository at this point in the history
  53. 19040 Framework for short-form amalgamations (#630)

    * - app version = 5.7.0
    - updated App header/title
    - added short-form amalgamation re-routing
    - added short-form amalgamation resource loading
    - updated Steppersimplified
    - added short-form amalgamation return links, etc
    - added short-form amalgamation route names
    - delete unneeded data in regular amalgamation resources
    - added short-form amalgamation resources and steps
    - broke up routes in sub-files
    - added short-form amalgamation routes
    - updated some store getters
    - combined views for regular + short-form
    - added conditionals in views for differences
    - added some computeds to keep template simple
    - updated unit tests
    - fixed missing effective date validity check
    
    * - deleted unused incorporation agreement type
    
    * - added option for Primary (vs Holding) Company
    
    * - fixed unit tests
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    77933d5 View commit details
    Browse the repository at this point in the history
  54. - app version = 5.7.1 (#634)

    - don't show Add Person for short-form amalgamation
    - set initial OfficeAddresses validity
    - deleted unneeded data from amalg IF
    - finished short amalg Office Addresses layout
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8c352dc View commit details
    Browse the repository at this point in the history
  55. Implemented the Continuation In Framework (#633)

    * Implemented the Continuation In Framework
    
    * some fixes related to continuation in interfaces
    
    * Rebased + fix rebase issues + fixed in response to comments
    
    * Small fixes in response to Sev's comments
    
    * Fixed typo
    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    085b659 View commit details
    Browse the repository at this point in the history
  56. 19036 Added "must include" checklist + refactored validation (#635)

    * - app version = 5.8.1
    - added checklist section + computeds
    - changed Business Table "valid" to "allOk"
    - refactored Amalgamating Businesses validation
    - cleaned up Information page layout
    - fixed bug where holding company is changed to amalgamating
    - fixed/updated unit tests
    
    * wip
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    928ec8c View commit details
    Browse the repository at this point in the history
  57. - app version = 5.8.2 (#638)

    - added handling for PRIMARY vs HOLDING
    - changed some "xxx Company" to "xxx Business" per uxpin changes
    - added separate information blurb for horizontal amalg
    - removed message box from review page (all amalgs)
    - added/updated unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5419984 View commit details
    Browse the repository at this point in the history
  58. - app version = 5.8.3 (#639)

    - fixed unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0166e64 View commit details
    Browse the repository at this point in the history
  59. Update Information.vue

    - changed "company" to "business" in Amalgamating Businesses blurb (for horizontal and vertical)
    severinbeauvais authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    25ec3ef View commit details
    Browse the repository at this point in the history
  60. 19037 Added processing for new holding/primary company (#640)

    * - added eslint rule
    - app version = 5.8.4
    - fixed parseAmalgamationDraft to async
    - added code for new holding/primary business
    - now save TING complete addresses
    - updated tables to show reg office mailing address
    - don't show actions menu for holding/primary business
    - added more actions menu only for short-form amalgamating businesses
    - make business table reactive to holding/primary change
    - update prepopulated data on file and pay
    - fixed Business Contact Info reactivity bug
    - opened name translations sub-menu to the left (per Yui)
    - now return the holding/primary business from refetchAmalgamatingBusinessesInfo()
    - added mixin method to fetch holding/primary business data and update prepopulated data
    - cleaned up parseAmalgamationDraft()
    - update prepopulated data on draft restore
    - fixed Phone Rules bug
    - added fetchDirectors() and fetchShareStructure() to Legal Services
    
    * - used separate messages for horiz versus vert (per Yui)
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6fca167 View commit details
    Browse the repository at this point in the history
  61. - app version = 5.8.5 (#643)

    - now save auth info instead of just email (so we don't have to re-fetch it later)
    - updated unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    edadfd6 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    e171c80 View commit details
    Browse the repository at this point in the history
  63. 19629 Update legal type when adopting a business' name or new NR (#645)

    * - app version = 5.8.6
    - imported latest shared correct-name components
    - pass in null entity type so it's not checked
    - if adopting a business' name, also adopt its legal type
    - when using a new NR, also use its legal type
    
    * - only show more actions menu for LEAR businesses
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c2fdc32 View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    bc257cf View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    a6520d2 View commit details
    Browse the repository at this point in the history
  66. Rebased

    jamespaologarcia authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    091c223 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    21e07d4 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    6272ad1 View commit details
    Browse the repository at this point in the history
  69. 19041 Finished validations + updated certify statements + updated uni…

    …t tests (#646)
    
    * - app version = 5.8.8
    - deleted useless isViteRunning getter (was only used in 1 place)
    - changed re-routing code to not push the wrong route to history
    - update misc comments
    - fixed amalgamation statement validation (was undefined on draft restore)
    - updated certify statements (for regular and short-form amalgamations)
    - fixed invalid date error in EffectiveDateTime
    - updated isAmalgamationInformationValid()
    - fixed amalgamation validation (ignore share structure validity for short-form amalg)
    - refactored Business Info test suite to handle regular vs horiz vs vert
    - misc cleanup
    
    * - set new resources when holding/primary business is changed
    
    * - also update resources when adopting a business' NOA or using a new NR
    - refactored resource update into separate method for use in multiple places
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8d23945 View commit details
    Browse the repository at this point in the history
  70. 19041 Created constants (enum) for resource phrases (#647)

    * - app version = 5.8.9
    - created constants (enum) for common resource phrases
    - updated misc resource files to use constants
    
    * - changed OFFENSE -> OFFENCE
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b442817 View commit details
    Browse the repository at this point in the history
  71. - app version = 5.8.10 (#649)

    - added validation for business not part of a FE amalgamation
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1a39467 View commit details
    Browse the repository at this point in the history
  72. - app version = 5.8.11 (#651)

    - delete officer email if it's null
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    16c0c9b View commit details
    Browse the repository at this point in the history
  73. 19458 - do not show/edit directors (#648)

    * 19458 - do not show/edit directors
    
    * 19458 - add unit tests
    
    * 19458 - add filtered person list
    
    * 19458 - update package version
    
    * 19458 - update function logic, fix lint error
    
    * 19458 - update package version
    ketaki-deodhar authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6f173ec View commit details
    Browse the repository at this point in the history
  74. - app version = 5.8.13 (#653)

    - removed redundant first certify bullet
    - set entity display to "business"
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f5b2fab View commit details
    Browse the repository at this point in the history
  75. - app version = 5.8.14 (#654)

    - imported updated correct-name shared component
    - now filter adoptee businesses here instead of in shared component
    - added filter for entity type
    - added test suite
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1cb39e5 View commit details
    Browse the repository at this point in the history
  76. 19698 Added Account-Id to auth api call + check for null auth info + …

    …small cleanup (#650)
    
    * - app version = 5.8.15
    - added get after set to update store
    - added check for empty auth info when re-fetching ting business info
    - added some safety checks when updating prepopulated data (ie, new holding/primary business)
    - moved accountId computed to store
    - added Account-Id header to fetchAuthInfo()
    - deleted some unused getters/local code
    - cleaned up some App unit tests
    
    * - added some line breaks between code blocks in legal services
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    69c4f4d View commit details
    Browse the repository at this point in the history
  77. - app version = 5.9.1 (#656)

    - use applicant phone/email (if available) to fetch NR on app start
    - use applicant phone/email (if available) to validate NR on file and pay
    - save applicant phone/email to draft amalgamation, continuation in and restoration
    - added store getter
    - misc cleanup
    - fixed unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9bc087f View commit details
    Browse the repository at this point in the history
  78. 19044 - Amalgamation unit tests (#655)

    * 19044 - unit tests for Short amalgmation resources
    
    * 19044 - clean up
    
    * 19044 - add comment
    
    * 19044 - remove comment
    
    * 19044 - remove comment
    
    * 19044 - update package version
    ketaki-deodhar authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1b5b76c View commit details
    Browse the repository at this point in the history
  79. 19750 Fixed error handling (#657)

    * - app version = 5.9.2
    - fixed error handling bug (missing await)
    - removed unneeded code in buildAmalgamationFiling()
    - updated some comments
    
    * - refactored ListPeopleAndRoles to retain original index for actions
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8fcab9d View commit details
    Browse the repository at this point in the history
  80. - app version = 5.9.3 (#658)

    - delete officer email property if it's empty ("")
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    06eb5cf View commit details
    Browse the repository at this point in the history
  81. 19756 Small change so prepopulated data overrides legal name (#659)

    * - app version = 5.9.4
    - updated some code comments
    - on draft resume, update prepopulated data after the legal name is restored (as we may override it)
    
    * - deleted obsolete comment
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    09cdae2 View commit details
    Browse the repository at this point in the history
  82. 19874 Changed some snackbar messages to dialogs (#660)

    * - app version = 5.9.5
    - used error dialog for "business not in LEAR" scenario
    - used error dialog for "unable to add business" scenario
    - used error dialog for "error marking new business" scenario
    - bolded labels in RegistriesContactInfo component
    - added generic error dialog component
    
    * - created test suite for new dialog
    
    * - rename dialog message -> text
    - update unit tests
    
    ---------
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2df3050 View commit details
    Browse the repository at this point in the history
  83. - app version = 5.9.6 (#661)

    - save region value instead of text (x2)
    - fixed unit test
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    363bcc5 View commit details
    Browse the repository at this point in the history
  84. - app version = 5.9.7 (#663)

    - handled Forbidden vs Not Found vs missing auth info scenarios separately
    - added status to Auth Info response to handle scenarios above
    - updated unit tests
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    eba44ea View commit details
    Browse the repository at this point in the history
  85. - app version = 5.9.8 (#664)

    - updated My Business Registry breadcrumb
    - updated Staff dashboard breadcrumb
    
    Co-authored-by: Severin Beauvais <[email protected]>
    2 people authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a30974e View commit details
    Browse the repository at this point in the history
  86. Update main.ts

    - added "await sleep" after console error so it displays before the alert
    severinbeauvais authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2073a23 View commit details
    Browse the repository at this point in the history
  87. Update BreadcrumbResource.ts

    - removed superfluous typing
    severinbeauvais authored and JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    be90f00 View commit details
    Browse the repository at this point in the history
  88. Configuration menu
    Copy the full SHA
    f2b37a4 View commit details
    Browse the repository at this point in the history
  89. fixed rebase issues 2

    JazzarKarim committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b134c6b View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge pull request #665 from JazzarKarim/18123-rebasing-legalname-2

    18123 rebased legal name FB with main
    JazzarKarim authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3f10fc3 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    0c685fd View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. - updated NAICS URL in example env file (#669)

    - app version = 6.0.1
    - updated NAICS API reference in vaults file
    
    Co-authored-by: Severin Beauvais <[email protected]>
    severinbeauvais and Severin Beauvais authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c6dc782 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. 20148 Updated to accommodate alternate name changes (#671)

    * 20148 Updated to accommodate alternate name changes
    
    * fixed comments
    
    * Fixed tests + comment
    
    * fixed typo
    
    * fallback to legal name if alternate name is not found + changed to use shared enum
    
    * reverted the code back to Unknown
    JazzarKarim authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    76f829f View commit details
    Browse the repository at this point in the history