Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13577 Package changes for Vue3 (PROTOTYPE) #444

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

13577 Package changes for Vue3 (PROTOTYPE) #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .browserslistrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
> 1%
last 2 versions
not ie <= 10
not dead
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remove polyfills for IE11 and maybe other old browsers.

I saw somewhere that Vue3 is not compatible with IE11 anyway, so I think this is a good change.

5 changes: 4 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ module.exports = {
},
extends: [
'plugin:vue/essential',
// 'plugin:vue/recommended',
'@vue/standard',
'@vue/typescript'
// '@vue/typescript/recommended'
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Sep 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking lines 9 and 11 are worthy changes but I'm trying to limit the impact of the upgrade. We can use recommended lint rules -- and fix what it finds -- later.

],
rules: {
'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
Expand All @@ -15,7 +17,8 @@ module.exports = {
},
parserOptions: {
parser: '@typescript-eslint/parser',
plugins: ['@typescript-eslint']
plugins: ['@typescript-eslint'],
ecmaVersion: 2020
},
overrides: [
{
Expand Down
1 change: 1 addition & 0 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ module.exports = {
babelConfig: true
}
},
// silent: true,
preset: '@vue/cli-plugin-unit-jest/presets/typescript-and-babel',
transformIgnorePatterns: []
}
Loading