Grad release 1.12.0

bcgov · Jan 15, 2024 · 8ef9501 · 8ef9501
2 parents 47edf5b + c349c74
commit 8ef9501
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/api/pom.xml b/api/pom.xml
@@ -10,7 +10,7 @@
 	</parent>
 	<groupId>ca.bc.gov.educ</groupId>
 	<artifactId>educ-grad-rule-engine-api</artifactId>
-	<version>1.8.53</version>
+	<version>1.8.54</version>
 	<name>educ-grad-rule-engine-api</name>
 	<description>Rule Engine API for GRAD team</description>
 

diff --git a/api/src/main/java/ca/bc/gov/educ/api/ruleengine/rule/MinElectiveCredits2023Rule.java b/api/src/main/java/ca/bc/gov/educ/api/ruleengine/rule/MinElectiveCredits2023Rule.java
@@ -86,7 +86,7 @@ private int processOthers(StudentCourse sc, int requiredCredits, int totalCredit
 	}
 	private int processLeftOverCredits(StudentCourse sc, int requiredCredits, int totalCredits, ProgramRequirement gradProgramRule) {
 		if((sc.isUsedInMatchRule() && sc.getLeftOverCredits() != null && sc.getLeftOverCredits() != 0)
-			&& (!gradProgramRule.getGraduationProgramCode().contains("2023") && !hasMatchTypeRule(sc.getGradReqMet()))) {
+			&& (gradProgramRule.getGraduationProgramCode().contains("2023") && hasMatchTypeRule(sc.getGradReqMet()))) {
 				if (totalCredits + sc.getLeftOverCredits() <= requiredCredits) {
 					totalCredits += sc.getLeftOverCredits();
 					sc.setCreditsUsedForGrad(sc.getCreditsUsedForGrad() + sc.getLeftOverCredits());