Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ndt 247 test banner says connected instead of connecting #3248

Merged
merged 3 commits into from
May 8, 2024
Merged

Ndt 247 test banner says connected instead of connecting #3248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc70947
fix(typo): connected to connecting
rafasdc May 7, 2024
726843a
fix(typo): connected to connecting
rafasdc May 7, 2024
4ea7fbb
Merge branch 'main' into NDT-247-Test-banner-says-Connected-instead-o…
rafasdc May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/HeaderBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const HeaderBanner: React.FC<Props> = ({
{environmentIndicator && !isProd && (
<StyledBaseHeaderBanner header="sub">
<StyledDiv>
Connected Communities BC portal{' '}
Connecting Communities BC portal{' '}
{isTest ? ' Test ' : ' Development '} environment.
</StyledDiv>
</StyledBaseHeaderBanner>
Expand Down
6 changes: 3 additions & 3 deletions app/tests/components/HeaderBanner.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('The Header Banner component', () => {
it('should render the correct banner when environment indicator on', () => {
renderStaticLayout(true);
const alert = screen.getByText(
/Connected Communities BC portal Development environment/
/Connecting Communities BC portal Development environment/
);

expect(alert).toBeInTheDocument();
Expand All @@ -39,7 +39,7 @@ describe('The Header Banner component', () => {
renderStaticLayout(false);
expect(
screen.queryByText(
/Connected Communities BC portal Development environment/
/Connecting Communities BC portal Development environment/
)
).not.toBeInTheDocument();
});
Expand All @@ -62,7 +62,7 @@ describe('The Header Banner component', () => {
mockOpenshiftNamespace.mockImplementationOnce(() => 'environment-prod');
renderStaticLayout(true);
expect(
screen.queryByText(/Connected Communities BC portal/)
screen.queryByText(/Connecting Communities BC portal/)
).not.toBeInTheDocument();
});

Expand Down
Loading