chore: refactor modal opening in project area page #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RRanath
force-pushed
the
NDT-282-Refactor-how-we-handle-project-area-modal-opening
branch
from
a176205
to
73a4ca1
Compare
AntBush
approved these changes
May 1, 2024
| @@ -379,6 +379,42 @@ const ApplicationForm: React.FC<Props> = ({ | |||
| const isOtherFundingSourcesPage = sectionName === 'otherFundingSources'; | |||
| const isReviewPage = sectionName === 'review'; | |||
|
|
|||
| const allZoneIntake = | |||
There was a problem hiding this comment.
Since this is a bool, we should rename this to isAllZoneIntake
Suggested change
| const allZoneIntake = | |
| const isAllZoneIntake = |
Comment on lines
389
to
390
| firstNationsLed: boolean, | ||
| nullAllowed: boolean = true |
There was a problem hiding this comment.
Same here that bools should use the is prefix
Suggested change
| firstNationsLed: boolean, | |
| nullAllowed: boolean = true | |
| isFirstNationsLed: boolean, | |
| isNullAllowed: boolean = true |
| // display new modal saying | ||
| // Invalid selection. You have indicated that this project is not led or supported by First Nations, therefore, you may only choose from zones 1,2,3 or 6. | ||
| setProjectAreaModalType('invalid-geographic-area'); | ||
| const projectAreaAccepted = isZoneSelectionValid( |
There was a problem hiding this comment.
Should stick to the is prefix for booleans
Suggested change
| const projectAreaAccepted = isZoneSelectionValid( | |
| const isProjectAreaAccepted = isZoneSelectionValid( | |
| //could also do isValidZoneSelection |
RRanath
deleted the
NDT-282-Refactor-how-we-handle-project-area-modal-opening
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #NDT-282