Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 error when CSV export happens for resource types that have no exportable attributes #1108

Open
bferguso opened this issue Oct 25, 2024 · 7 comments
Assignees
Labels
approved Issue has been approved for development bcrhp BCRHP Specific Issue bug Something isn't working

Comments

@bferguso
Copy link
Collaborator

bferguso commented Oct 25, 2024

When performing a CSV export that includes resources that don't have any exportable fields a HTTP 500 error message occurs. Need to fix this by either

  1. fixing the arches core issue causing this to happen or
  2. making sure all resource types have at least one exportable attribute (or all of them exportable)

From the previous ticket:

  1. Internal users get an error message. This is likely because heritage site submission and sandcastle don't have define csv exports - can we make them have csv exports just simply on all fields?
    Image
@bferguso bferguso added bcrhp BCRHP Specific Issue bug Something isn't working labels Oct 25, 2024
@bferguso bferguso added this to the BCRHP - pre-7.6.x bugfixes milestone Oct 25, 2024
@bferguso bferguso self-assigned this Oct 25, 2024
@bferguso bferguso added the approved Issue has been approved for development label Oct 25, 2024
@bferguso
Copy link
Collaborator Author

This appears to be because there are cards in the Site Submission and Sandcastle resource models that have null sort orders. There is also one card in Heritage Site resource model, but that won't cause problems as we have an alternate mechanism to create CSV from that resource model.

@bferguso
Copy link
Collaborator Author

bferguso commented Oct 28, 2024

@emjohnst - I'm seeing an issue with Site Submissions that if there is a card for the Submission Documents, but there are no documents it is raising an export error. Let's log that issue and handle it after 7.6.x? Created an issue here: #1112

The fix is to either add a file or delete the card without any associated files.

@emjohnst
Copy link
Collaborator

@bferguso Another minor issue - there is a time difference between download time stamp and actual time. Is this an easy fix to set proper time zone or an arches core bug?
Image

@bferguso
Copy link
Collaborator Author

bferguso commented Oct 29, 2024

This is unrelatd to the 500 error. Can you please raise as a separate issue? I'll need to look into that seperately. If the 500 error is fixed this ticket can be move to Done.

@emjohnst
Copy link
Collaborator

@KatieMcEvoy can you test the export on more than 2000 records (internally, and as public user) and see if you get an email? In one of my tests I still got an email but I can't seem to replicate it. Make sure to delete cache/browser history before testing. Thanks!

@KatieMcEvoy
Copy link
Collaborator

It works normally as long as the "Report Link" is not selected.
When it is selected I received the following error message
Capture

@bferguso
Copy link
Collaborator Author

bferguso commented Oct 30, 2024

Fixed so selecting the report link doesn't break the export. This is only available to internal users for Heritage Site. Currently the link is not correct, which should probably be fixed. This should be addressed as a separate issue, and perhaps it should wait until after 7.6.x as this has always been the case due to it being configured due the the reverse proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Issue has been approved for development bcrhp BCRHP Specific Issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants