Change swift_library alwayslink default to True
#1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
brentleyjones
force-pushed
the
bj/swift_library-alwayslink
branch
from
27ea4e6
to
443dc3a
Compare
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
This also changes the default for the `swift_common.create_linking_context_from_compilation_outputs` api. SwiftPM works by linking all the .o files, and how .swift sources map to .o files can be dependent on the compiler options, so this should end up in a state that seem users familiar with SwiftPM/Xcode will expect. Remove the private feature that was supporting this by honoring the objc flag. PiperOrigin-RevId: 558766347 (cherry picked from commit c58d81a) Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/swift_library-alwayslink
branch
from
443dc3a
to
5136518
Compare
luispadron
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the default for the
swift_common.create_linking_context_from_compilation_outputsapi.SwiftPM works by linking all the .o files, and how .swift sources map
to .o files can be dependent on the compiler options, so this should
end up in a state that seem users familiar with SwiftPM/Xcode will
expect.
Remove the private feature that was supporting this by honoring the
objc flag.
PiperOrigin-RevId: 558766347
(cherry picked from commit c58d81a)