Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First shot at implementing #890
Main implementation
I followed guidance from @fmeum and based this implementation on the runfiles library of
rules_python
where applicable since this was pointed as the reference implementation.The non applicable parts, especially the runtime computation of the runfiles directory has been inspired by the implementation in
rules_rust
.Source repository problem
One particularity that comes with
bzlmod
is that the lookup function must know about the caller canonical repository name to lookup the proper repo mapping in the generated_repo_mapping
.Almost all implementations out there either use runtime stacktrace introspection mechanisms to deduce the source repository from the path of the source file of the function calling the runfiles
rlocation
method (Go, Python), or other compile time flavors provided by the language (Rust, Java).Since none of these options are feasible in Swift, I chose to follow what the Runfiles C++ library does: provide a magical constant to be passed to the constructor of the
Runfiles
class for every target that depends on the@rules_swift//swift/runfiles
.the path lookup can then be performed by prefixing the path of the runfile with the workspace under which it lives:
The way this Constants enum is provided to each target that depends on
@rules_swift//swift/runfiles
has been hacked quickly for the proof of concept but will have to be discussed with therules_swift
maintainers for a correct implementation. Seerunfiles.bzl
.Note that currently, passing the runfiles library as
private_deps
doesn't work.TODO