Skip to content

Commit

Permalink
Addressed new linter issues
Browse files Browse the repository at this point in the history
  • Loading branch information
UebelAndre committed Oct 18, 2024
1 parent fa3dc85 commit d40d623
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 15 deletions.
6 changes: 3 additions & 3 deletions crate_universe/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ impl Serialize for CrateId {
}

struct CrateIdVisitor;
impl<'de> Visitor<'de> for CrateIdVisitor {
impl Visitor<'_> for CrateIdVisitor {
type Value = CrateId;

fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
Expand Down Expand Up @@ -701,7 +701,7 @@ impl Serialize for CrateNameAndVersionReq {
}

struct CrateNameAndVersionReqVisitor;
impl<'de> Visitor<'de> for CrateNameAndVersionReqVisitor {
impl Visitor<'_> for CrateNameAndVersionReqVisitor {
type Value = CrateNameAndVersionReq;

fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
Expand Down Expand Up @@ -795,7 +795,7 @@ impl<'de> Deserialize<'de> for VersionReqString {
{
struct StringVisitor;

impl<'de> Visitor<'de> for StringVisitor {
impl Visitor<'_> for StringVisitor {
type Value = String;

fn expecting(&self, formatter: &mut Formatter) -> fmt::Result {
Expand Down
2 changes: 1 addition & 1 deletion crate_universe/src/utils/starlark/label.rs
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ impl Serialize for Label {
}

struct LabelVisitor;
impl<'de> Visitor<'de> for LabelVisitor {
impl Visitor<'_> for LabelVisitor {
type Value = Label;

fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
Expand Down
4 changes: 2 additions & 2 deletions crate_universe/src/utils/starlark/select_dict.rs
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ where
U: SelectableOrderedValue,
T: SelectableValue;

impl<'a, U, T> Serialize for SelectInner<'a, U, T>
impl<U, T> Serialize for SelectInner<'_, U, T>
where
U: SelectableOrderedValue,
T: SelectableValue,
Expand Down Expand Up @@ -190,7 +190,7 @@ where
U: SelectableOrderedValue,
T: SelectableValue;

impl<'a, U, T> Serialize for SelectUnmapped<'a, U, T>
impl<U, T> Serialize for SelectUnmapped<'_, U, T>
where
U: SelectableOrderedValue,
T: SelectableValue,
Expand Down
4 changes: 2 additions & 2 deletions crate_universe/src/utils/starlark/select_list.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ where
where
T: SelectableValue;

impl<'a, T> Serialize for SelectInner<'a, T>
impl<T> Serialize for SelectInner<'_, T>
where
T: SelectableValue,
{
Expand All @@ -160,7 +160,7 @@ where
where
T: SelectableValue;

impl<'a, T> Serialize for SelectUnmapped<'a, T>
impl<T> Serialize for SelectUnmapped<'_, T>
where
T: SelectableValue,
{
Expand Down
4 changes: 2 additions & 2 deletions crate_universe/src/utils/starlark/select_scalar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ where
where
T: SelectableScalar;

impl<'a, T> Serialize for SelectInner<'a, T>
impl<T> Serialize for SelectInner<'_, T>
where
T: SelectableScalar,
{
Expand All @@ -140,7 +140,7 @@ where
where
T: SelectableScalar;

impl<'a, T> Serialize for SelectUnmapped<'a, T>
impl<T> Serialize for SelectUnmapped<'_, T>
where
T: SelectableScalar,
{
Expand Down
4 changes: 2 additions & 2 deletions crate_universe/src/utils/starlark/select_set.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ where
where
T: SelectableOrderedValue;

impl<'a, T> Serialize for SelectInner<'a, T>
impl<T> Serialize for SelectInner<'_, T>
where
T: SelectableOrderedValue,
{
Expand All @@ -175,7 +175,7 @@ where
where
T: SelectableOrderedValue;

impl<'a, T> Serialize for SelectUnmapped<'a, T>
impl<T> Serialize for SelectUnmapped<'_, T>
where
T: SelectableOrderedValue,
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ impl Serialize for TargetCompatibleWith {

struct SelectInner<'a>(&'a BTreeSet<String>);

impl<'a> Serialize for SelectInner<'a> {
impl Serialize for SelectInner<'_> {
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
where
S: Serializer,
Expand Down
4 changes: 2 additions & 2 deletions util/process_wrapper/flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ struct FlagDef<'a, T> {
output_storage: &'a mut Option<T>,
}

impl<'a, T> fmt::Display for FlagDef<'a, T> {
impl<T> fmt::Display for FlagDef<'_, T> {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
write!(f, "{}\t{}", self.name, self.help)
}
}

impl<'a, T> fmt::Debug for FlagDef<'a, T> {
impl<T> fmt::Debug for FlagDef<'_, T> {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("FlagDef")
.field("name", &self.name)
Expand Down

0 comments on commit d40d623

Please sign in to comment.