Skip to content

Commit

Permalink
RequestMetadata: Make ToolDetails a recursive structure
Browse files Browse the repository at this point in the history
This adds a `wrapped_tool_details` field to the `ToolDetails` message,
which allows all tools involved in the sending and receipt of a request
to record their information in the request metadata.

For example, it allows tracking information about both the user-facing
client tool and a potential client-side proxy tool to be attached to the
request in a structured fashion.
  • Loading branch information
ColdrickSotK committed Aug 6, 2024
1 parent 0d21f29 commit c11dd37
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions build/bazel/remote/execution/v2/remote_execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2088,6 +2088,13 @@ message ToolDetails {

// Version of the tool used for the request, e.g. 5.0.3.
string tool_version = 2;

// Details of other tools involved in the request
// This recursive structure allows each tool involved in a request to
// have its name and version included in the request metadata.
// For example, a client-side proxy might include the client tool's
// initial ToolDetails here along with its own name and version.
ToolDetails wrapped_tool_details = 3;
}

// An optional Metadata to attach to any RPC request to tell the server about an
Expand Down

0 comments on commit c11dd37

Please sign in to comment.