Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_wasm) have been updated in this PR. Please review the changes.

@ouillie ouillie mentioned this pull request Oct 17, 2024
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 18, 2024
@ouillie
Copy link

ouillie commented Oct 20, 2024

Going to try fixing the glibc compatibility issues upstream.

Regarding the Bazel 6.x failures, I'm a bit confused about the need for a WORKSPACE file for something that's being distributed via the BCR. Is there any documentation on what Bazel expects to find in the WORKSPACE file? I tried reproducing locally like this:

docker run -it gcr.io/bazel-public/ubuntu2004
git clone https://github.com/vimana-cloud/rules_wasm.git
cd rules_wasm/example
USE_BAZEL_VERSION=6.5.0 bazel test //...

But it just said:

Unable to find package for @rules_wasm//:wasm.bzl: The repository '@rules_wasm' could not be resolved: Repository '@rules_wasm' is not defined.

I'm assuming there's some sort of shim I'm missing? I noticed on BuildKite it refers to the repository as //:rules_wasm~override but there's a lot going on and it's kinda hard to tell what the ~override means.

@meteorcloudy
Copy link
Member

@ouillie With Bazel 6, Bzlmod was not enabled by default and a WORKSPACE file is still required to identify to repo root.

To reproduce the error, you'll need to add --enable_workspace to the build command.

It's also fine if you want to drop Bazel 6 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants