Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add google-cloud-cpp v2.29.0 #2742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add google-cloud-cpp v2.29.0 #2742

wants to merge 1 commit into from
+148 −0

Conversation

mering
Copy link
Contributor

@mering mering commented Sep 9, 2024

No description provided.

@bazel-io
Copy link
Member

bazel-io commented Sep 9, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (google_cloud_cpp) have been updated in this PR. Please review the changes.

@mering
Copy link
Contributor Author

mering commented Sep 9, 2024

@meteorcloudy @Wyverald could you please trigger the tests? Thanks.

@Wyverald Wyverald added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Sep 10, 2024
@Wyverald
Copy link
Member

@meteorcloudy @Wyverald could you please trigger the tests? Thanks.

Done.

@mering mering force-pushed the add-google-cloud-cpp branch 3 times, most recently from 976a2ca to b13de6b Compare September 10, 2024 16:14
mmorel-35
mmorel-35 reviewed Sep 10, 2024
View reviewed changes
modules/google_cloud_cpp/2.29.0/MODULE.bazel
"""Idiomatic C++ client libraries for Google Cloud Platform."""

module(
name = "google_cloud_cpp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don’t you keep it named google-cloud-cpp ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought dashes sometimes lead to problems. If this is not the case, I can rename it of course.

Copy link
Contributor

@mmorel-35 mmorel-35 Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not aware of this kind of issue. Have you seen it with bzlmod or only with workspace ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was Python pip packages replacing dashes with underscores for some reason. But this might be related to Python importpath or similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I noticed it has been chosen like this from upstream already. So I didn't change it in a patch. Would it be preferable to change it with a patch for the initial upload?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorel-35 mmorel-35 mmorel-35 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mering @bazel-io @Wyverald @mmorel-35