Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swift.experimental_rules_swift_package_manager flag #917

Merged

Conversation

thiagohmcruz
Copy link
Contributor

No description provided.

rules/framework.bzl Outdated Show resolved Hide resolved
Co-authored-by: Jonathan Schear <[email protected]>
@gyfelton
Copy link
Contributor

actually one thing i realized is this branch does not contain fixes for latest rules, so any test that fails with latest rules true can be ignored

@thiagohmcruz thiagohmcruz marked this pull request as ready for review September 17, 2024 20:02
@thiagohmcruz thiagohmcruz merged commit c348661 into cshi/vfsoverlay-fix Sep 17, 2024
11 of 21 checks passed
@thiagohmcruz thiagohmcruz deleted the thiago/rules_swift_package_manager-1 branch September 17, 2024 20:05
@gyfelton gyfelton restored the thiago/rules_swift_package_manager-1 branch September 18, 2024 19:10
gyfelton added a commit that referenced this pull request Sep 18, 2024
…` back to master branch (#922)

already approved at #917

Now it's about landing it in master and since it is guarded by a flag,
it's no op unless you enable this feature

Co-authored-by: Thiago Cruz <[email protected]>
Co-authored-by: Jonathan Schear <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants