Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 2 of passing compilation context #908

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    ceceeeb View commit details
    Browse the repository at this point in the history
  2. Pass compilation context via swift info in hmap creation due to rules…

    …_swift 2.1.1 (#906)
    
    One of the CI error is:
    ```
    error: generate-pch command failed with exit code 1 (use -v to see invocation)
    tests/ios/unit-test/test-imports-app/TestImports-App-Bridging-Header.h:1:9: error: 'TestImports-App/Header2.h' file not found
    #import <TestImports-App/Header2.h>
            ^
    1 error generated.
    <unknown>:0: error: failed to emit precompiled header 'bazel-out/ios-sim_arm64-min12.0-applebin_ios-ios_sim_arm64-dbg-ST-c2aefc9133a8/bin/_pch_output_dir/TestImports-App-Bridging-Header-swift_28IU2BV1DK30K-clang_1FNSWCOAS4SUQ.pch' for bridging header 'tests/ios/unit-test/test-imports-app/TestImports-App-Bridging-Header.h'
    ```
    This is because this header was suppose to be an input to Swift compile
    via hmap creation rule. But in this breaking change
    bazelbuild/rules_swift@d68b214
    rules_swift stopped collecting compilation context from `CcInfo` if the
    target is Swift code (line 1555 of `swift/internal/compiling.bzl`).
    Instead it depends on reading the same info from
    `clang_module.compilation_context` which is available from `SwiftInfo`
    provider (SwiftInfo -> modules -> clang)
    
    This PR deals with header maps side where we propagate compilation
    context via this `clang` module
    
    Next step is to do the same for other places where we need to pass the
    compilation context
    
    CI for this PR should no longer produce this error (but will still fail
    on some other tests)
    gyfelton authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ac323d2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5d7a24b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. pass in compilation_context to build the clang module and not based o…

    …n framework_files.output
    gyfelton committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    578af24 View commit details
    Browse the repository at this point in the history