Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust gazelle for upcoming rules_go changes #1889

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dzbarsky
Copy link
Contributor

@dzbarsky dzbarsky commented Aug 23, 2024

What type of PR is this?
Code refactor/future-proofing

What package or component does this PR mostly affect?
gazelle binary

What does this PR do? Why is it needed?

  • rules_go is deprecating some attributes from go_context (such as package_list), so stop using it.
  • binaries should not return the library/source provider so they cannot be accidentally used as deps/embed in other rules
  • I am also considering revamping how runfiles collection works in rules_go, so we can just collect the runfiles from languages directly to insulate ourselves from future changes there.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it so that this works with both the current and the upcoming version of rules_go? It wouldn't matter for Bzlmod, but WORKSPACE users will have an easier time updating if that's the case.

@dzbarsky
Copy link
Contributor Author

dzbarsky commented Sep 1, 2024

Can we make it so that this works with both the current and the upcoming version of rules_go? It wouldn't matter for Bzlmod, but WORKSPACE users will have an easier time updating if that's the case.

The rules_go changes don't break gazelle, we can land this future-proofing after the release is cut.

Edit:except the binary providers. Hmmm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants