Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DataAdapter -> Adapter #222

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Rename DataAdapter -> Adapter #222

merged 2 commits into from
Oct 26, 2024

Conversation

LarsKue
Copy link
Contributor

@LarsKue LarsKue commented Oct 24, 2024

Since the data adapter is such a central part of the Bayesian Workflow now, we decided to rename it to simply "Adapter".

@LarsKue LarsKue added refactoring Some code shall be redesigned user interface Changes to the user interface and improvements in usability labels Oct 24, 2024
@LarsKue LarsKue self-assigned this Oct 24, 2024
@LarsKue LarsKue added this to the BayesFlow 2.0 milestone Oct 24, 2024
Copy link
Contributor

@paul-buerkner paul-buerkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side.

@stefanradev93
Copy link
Contributor

Thanks, Lars! Can you resolve the conflicts in the starter notebook (ie Valentin made some small changes for better performance) and merge?

@stefanradev93 stefanradev93 merged commit b3fdec8 into dev Oct 26, 2024
13 checks passed
@stefanradev93 stefanradev93 deleted the rename-data-adapter branch October 26, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Some code shall be redesigned user interface Changes to the user interface and improvements in usability
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants