Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dbg:stop_clear/0 is deprecated and will be removed in OTP 27; #1014

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix dbg:stop_clear/0 is deprecated and will be removed in OTP 27; #1014

wants to merge 1 commit into from

Conversation

asyncmind0
Copy link

  • using dbg:stop/0 instead

@martinsumner
Copy link
Contributor

The function dbg:stop changed OTP 24 -> OTP 25 to make it the same as dbg:stop_clear/0, but in OTP 24 the two functions still have different behaviour:

https://www.erlang.org/docs/24/man/dbg#stop-0
https://www.erlang.org/docs/24/man/dbg#stop_clear-0
https://www.erlang.org/docs/25/man/dbg#stop-0

So to implement this changeI think you need to check the OTP_RELEASE and do stop if OTP_RELEASE >= 25, and stop_clear otherwise.

There's a question over whether we should just remove riak_core_tracer altogether. I don't think it is used anywhere other than riak_kv_get_fsm. @nsaadouni @tburghart - do either of your teams make use of this riak_core_tracer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asyncmind0 @martinsumner