Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be a bit more patient during tests #637

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

mdkent
Copy link
Member

@mdkent mdkent commented Jan 8, 2024

Doing lots of local testing today and I'm seeing reasonably consistent local failures at 20 seconds:

[+] Running 7/7
 ✔ Container kamal-test-vm2-1            Removed                                                                                                                             1.2s
 ✔ Container kamal-test-load_balancer-1  Removed                                                                                                                             0.0s
 ✔ Container kamal-test-vm1-1            Removed                                                                                                                             1.2s
 ✔ Container kamal-test-deployer-1       Removed                                                                                                                             1.2s
 ✔ Container kamal-test-registry-1       Removed                                                                                                                             0.1s
 ✔ Container kamal-test-shared-1         Removed                                                                                                                             1.2s
 ✔ Network kamal-test_default            Removed                                                                                                                             0.0s
E

Error:
MainTest#test_config:
RuntimeError: Container not healthy after 20 seconds
    /Users/mkent/Work/basecamp/kamal/test/integration/integration_test.rb:111:in `wait_for_healthy'
    /Users/mkent/Work/basecamp/kamal/test/integration/integration_test.rb:8:in `block in <class:IntegrationTest>'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:445:in `instance_exec'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:445:in `block in make_lambda'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:199:in `block (2 levels) in halting'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:687:in `block (2 levels) in default_terminator'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:686:in `catch'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:686:in `block in default_terminator'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:200:in `block in halting'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:595:in `block in invoke_before'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:595:in `each'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:595:in `invoke_before'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/callbacks.rb:106:in `run_callbacks'
    /Users/mkent/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/activesupport-7.0.4.3/lib/active_support/testing/setup_and_teardown.rb:41:in `before_setup'


bin/test Users/mkent/Work/basecamp/kamal/test/integration/main_test.rb:45
<snip>
Finished in 206.054114s, 1.9655 runs/s, 5.6975 assertions/s.
405 runs, 1174 assertions, 0 failures, 1 errors, 0 skips

Suggest we wait a bit longer.

@mdkent mdkent requested a review from djmb January 8, 2024 21:42
Seeing reasonably consistent local failures at 20 seconds.
@mdkent mdkent force-pushed the tests-wait-longer-for-health branch from 6fabe94 to 9c681d4 Compare January 9, 2024 16:22
@djmb djmb merged commit 8b6d830 into main Jan 9, 2024
7 checks passed
@djmb djmb deleted the tests-wait-longer-for-health branch January 9, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants