Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set an absolute directory path #507

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

leonvogt
Copy link
Contributor

@leonvogt leonvogt commented Oct 1, 2023

This PR will introduce the option to set an absolute directory path.

Before - For example, a Redis accessory directory like:

  • data:/data would create the directory $PWD/my-appname-redis/data
  • /var/lib/redis:/data would create the directory $PWD/my-appname-redis//var/lib/redis

After - With this change, a Redis accessory directory like:

  • data:/data would create the directory $PWD/my-appname-redis/data
  • /var/lib/redis:/data would create the directory /var/lib/redis

The decision on whether Kamal will create an absolute or relative directory is based on the presence of a leading / in the path.

Please note that this change may introduce a breaking change for some users...

resolves #453

@leonvogt leonvogt force-pushed the introduce-absolute-accessories-paths branch from 2445d6c to 862b4d8 Compare October 21, 2023 15:00
lib/kamal/configuration/accessory.rb Outdated Show resolved Hide resolved
@leonvogt leonvogt force-pushed the introduce-absolute-accessories-paths branch from 862b4d8 to f339626 Compare November 3, 2023 21:48
@bendangelo
Copy link

Can this get reviewed again? I would really like this change.

@djmb djmb merged commit 175e3bc into basecamp:main Nov 28, 2023
6 checks passed
@leonvogt leonvogt deleted the introduce-absolute-accessories-paths branch December 19, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessory Data: Directories vs Volumes
4 participants