Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the env check #499

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Remove the env check #499

merged 1 commit into from
Oct 30, 2023

Conversation

djmb
Copy link
Collaborator

@djmb djmb commented Sep 25, 2023

The env check is not needed anymore as all the commands rely on the env files having already been created remotely.

The only place the env is needed is when running kamal env push and that will still raise an appropriate error.

The env check is not needded anymore as all the commands rely on the
env files having already been created remotely.

The only place the env is needed is when running `kamal env push` and
that will still raise an apropriate error.
@snopoke
Copy link

snopoke commented Oct 27, 2023

Would be great to get this merged and released!

@djmb djmb merged commit d2214b4 into main Oct 30, 2023
6 checks passed
@djmb djmb deleted the env-only-needed-for-push branch October 30, 2023 08:22
@djmb
Copy link
Collaborator Author

djmb commented Nov 3, 2023

@snopoke - that's released now in Kamal v1.1.0 👍

@jmarchello
Copy link

@djmb i just want to thank you for this change. This was a pain point for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants