prevent escape '#' when generating env_file string #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmb
reviewed
Oct 22, 2024
test/env_file_test.rb
Outdated
| @@ -11,6 +11,16 @@ class EnvFileTest < ActiveSupport::TestCase | |||
| Kamal::EnvFile.new(env).to_s | |||
| end | |||
|
|
|||
| test "to_s won't escape '#'" do | |||
| env = { | |||
| "foo" => "\#$foo", | |||
There was a problem hiding this comment.
Can you change these to # instead of \#? They mean the same thing and the \ makes it seem like there's some extra escaping going on that isn't really there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents escape
#character when generating the string used by docker--envargument.The
#was escaped becauseString#dumpalso consider ruby interpolation sequences as special characters, so a secret set asPASSWORD=foo#$123changed toPASSWORD=foo\#$123inside the container.