Merge pull request #1045 from junket/allow-false-env-var-value

Allow false env var value
basecamp · Oct 23, 2024 · 66f6e8b · 66f6e8b
2 parents a3e5505 + 6d1d7a4
commit 66f6e8b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/kamal/utils.rb b/lib/kamal/utils.rb
@@ -12,6 +12,8 @@ def argumentize(argument, attributes, sensitive: false)
         attr = "#{key}=#{escape_shell_value(value)}"
         attr = self.sensitive(attr, redaction: "#{key}=[REDACTED]") if sensitive
         [ argument, attr ]
+      elsif value == false
+        [ argument, "#{key}=false" ]
       else
         [ argument, key ]
       end

diff --git a/test/utils_test.rb b/test/utils_test.rb
@@ -2,8 +2,8 @@
 
 class UtilsTest < ActiveSupport::TestCase
   test "argumentize" do
-    assert_equal [ "--label", "foo=\"\\`bar\\`\"", "--label", "baz=\"qux\"", "--label", :quux ], \
-      Kamal::Utils.argumentize("--label", { foo: "`bar`", baz: "qux", quux: nil })
+    assert_equal [ "--label", "foo=\"\\`bar\\`\"", "--label", "baz=\"qux\"", "--label", :quux, "--label", "quuz=false" ], \
+      Kamal::Utils.argumentize("--label", { foo: "`bar`", baz: "qux", quux: nil, quuz: false })
   end
 
   test "argumentize with redacted" do