Filter correctly for empty destinations

An empty destination should only filter container with empty destination, not pick up all containers. Fixes: #1184
basecamp · Nov 4, 2024 · 2f59a43 · 2f59a43
1 parent 685312c
commit 2f59a43
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 52 deletions.
diff --git a/lib/kamal/commands/app.rb b/lib/kamal/commands/app.rb
@@ -105,7 +105,7 @@ def extract_version_from_name
 
     def filters(statuses: nil)
       [ "label=service=#{config.service}" ].tap do |filters|
-        filters << "label=destination=#{config.destination}" if config.destination
+        filters << "label=destination=#{config.destination}"
         filters << "label=role=#{role}" if role
         statuses&.each do |status|
           filters << "status=#{status}"