check creation time for database to sanity check if the incremental is valid #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for if the incremental backup will be valid
kjetilho
added a commit
to kjetilho/rl-bareos
that referenced
this pull request
Dec 7, 2017
incorporates my two pull requests: bareos/bareos-contrib#28 bareos/bareos-contrib#29
It is much safer and simpler to just look for the oldest table in this instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a server very close to being put into production which got an initial full backup, and then just before entering production, the database was wiped and reinitialised. the LSN was sufficiently similar, so Bareos happily made incremental backups off a bogus base.
(luckily we did not need a restore before discovering the issue :-)