Fix some consts visibility in kafkacluster_types.go #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Darren Lau <[email protected]>
Kuvesz
approved these changes
Aug 25, 2023
pregnor
approved these changes
Aug 25, 2023
bartam1
pushed a commit
that referenced
this pull request
Aug 30, 2023
* Eliminate hardcoded values + move them at the beginning of file * Added some comments to defaults * Update pod.go * Apply suggestions from code review Co-authored-by: Darren Lau <[email protected]> * Fix visibility of some consts * Build fix --------- Co-authored-by: Darren Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mihai found some consts are not available publicly for unit test. I fixed them.
The original PR: #1043
I have tested this PR with a replace directive in go.mod and now the
make all lintworks.Type of Change
Checklist