Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint tests/e2e #1051

Merged
merged 2 commits into from
Aug 30, 2023
Merged

lint tests/e2e #1051

merged 2 commits into from
Aug 30, 2023

Conversation

mihaialexandrescu
Copy link
Contributor

Description

  • Add linting for module tests/e2e in make lint
  • Fix linting issues in module tests/e2e
  • Annotate Makefile

Type of Change

  • Refactor

@mihaialexandrescu mihaialexandrescu marked this pull request as ready for review August 28, 2023 07:34
@mihaialexandrescu mihaialexandrescu requested a review from a team as a code owner August 28, 2023 07:34
panyuenlau
panyuenlau approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@panyuenlau panyuenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning up the formatting!

pregnor
pregnor approved these changes Aug 30, 2023
View reviewed changes
tests/e2e/k8s.go Show resolved Hide resolved
Kuvesz
Kuvesz approved these changes Aug 30, 2023
View reviewed changes
.golangci.yml Show resolved Hide resolved
@mihaialexandrescu mihaialexandrescu merged commit 4285032 into master Aug 30, 2023
4 checks passed
@mihaialexandrescu mihaialexandrescu deleted the fix/linters_esp_e2etest branch August 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregnor pregnor pregnor approved these changes

@panyuenlau panyuenlau panyuenlau approved these changes

@Kuvesz Kuvesz Kuvesz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mihaialexandrescu @pregnor @panyuenlau @Kuvesz