Fix CC operations issues with controller-only nodes in KRaft #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once #1023 is merged into master, will change the target branch of this PR to master to smoothen the review process a bit |
|
Main PR has been closed, see this #1023 (comment) for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CC doesn't have direct access to controller-only nodes, hence we need to exclude the controller-only nodes from all the CC actions. See this comment for details: #1023 (comment).
TODO:
graceActionStatefrom all the controller-only nodes' status , right now, thegraceActionStateis still shown for the controller-only nodes and this is a false information because there is no graceful actions can be done against the controller-only nodesType of Change
Checklist