validate kafkauser annotations before creating csr #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update koperator api * use CertManagerSignerNamePrefix const from api package
pregnor
previously approved these changes
Jul 20, 2023
|
It would be nice to have this validation with webhook also. We already has a draft PR (#968) regarding validating webhook for kafkaUser. It would be nice to add this validation into that one. I will write a comment into that ticket. |
6 tasks
bartam1
previously approved these changes
Jul 21, 2023
Co-authored-by: Patrik Egyed <[email protected]>
bartam1
approved these changes
Jul 24, 2023
pregnor
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CertManagerSignerNamePrefixconstant from the API package everywhereType of Change
Checklist