Added internal SSL listener test #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuvesz
force-pushed
the
tests/e2e-ssl-produce-consume
branch
from
53ec398
to
50ecf33
Compare
pregnor
previously approved these changes
Jul 20, 2023
tests/e2e/kafka.go
Outdated
Comment on lines
55
to
61
| templateParameters := map[string]interface{}{ | ||
| "Name": userName, | ||
| "Namespace": kubectlOptions.Namespace, | ||
| } | ||
| if tlsSecretName != "" { | ||
| templateParameters["TLSSecretName"] = tlsSecretName | ||
| } |
There was a problem hiding this comment.
Note: In the future we might want to extract these into a kafkaUser(userName, namespace, optionalTLSSecretName string) (KafkaUser, error) function, looks reusable.
There was a problem hiding this comment.
Hm, fair, I'll add it to the internal refactor ticket if that is okay.
pregnor
previously approved these changes
Jul 20, 2023
panyuenlau
previously approved these changes
Jul 20, 2023
pregnor
approved these changes
Jul 26, 2023
panyuenlau
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added SSL support for internal listener E2E tests.
Type of Change
Checklist