add kafkauser annotation validations #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
reviewed
Jul 17, 2023
pregnor
previously approved these changes
Jul 20, 2023
bartam1
reviewed
Jul 20, 2023
Kuvesz
previously approved these changes
Jul 20, 2023
Kuvesz
approved these changes
Jul 20, 2023
pregnor
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validators and whitelist for
KafkaUserspec annotations.Only cert-manager pki backend signer annotations are validated. The whitelist contains only one annotation -
experimental.cert-manager.io/request-duration.The kafkauser controller's side implementation and the
CertManagerSignerNamePrefixreferences update will be pushed after bumping the API version.Annotations' structs, methods, and interfaces are currently private and may be turned public in the future if needed.
Type of Change
Checklist