Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change os.rename to os.replace in pre-render.py #843

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

DrEntropy
Copy link
Contributor

Building the Bambi docs with quarto was giving a "file exists" error during pre-render while trying to rename "CHANGELOG.md" to "changelog.qmd". Simply changing os.rename to os.replace fixes this.

An alternative would be to add the CHANGELOG.md to the _quarto.yml explicitly (quarto can render md too)

@DrEntropy DrEntropy changed the title change rename to replace in pre-render.py change os.rename to os.replace in pre-render.py Sep 7, 2024
@tomicapretto
Copy link
Collaborator

Building the Bambi docs with quarto was giving a "file exists" error during pre-render while trying to rename "CHANGELOG.md" to "changelog.qmd". Simply changing os.rename to os.replace fixes this.

An alternative would be to add the CHANGELOG.md to the _quarto.yml explicitly (quarto can render md too)

Thanks @DrEntropy for the contribution! I'll merge this once CI is green. Regarding Quarto, I'm aware we can add CHANGELOG.md to _quarto.yml. However, the last time I tried it, it was not working as expected. If I recall correctly, a non-rendered version of the file was being displayed in our webpage.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (038610c) to head (6e3ca83).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
- Coverage   89.82%   89.71%   -0.11%     
==========================================
  Files          47       47              
  Lines        3991     3997       +6     
==========================================
+ Hits         3585     3586       +1     
- Misses        406      411       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomicapretto tomicapretto merged commit 516d7bd into bambinos:main Sep 8, 2024
4 checks passed
@DrEntropy DrEntropy deleted the fix_pre_render branch September 8, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants