Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for using offset, addressing issue #418 #842

Merged
merged 12 commits into from
Sep 8, 2024

Conversation

DrEntropy
Copy link
Contributor

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@DrEntropy
Copy link
Contributor Author

I added at the end the equivalent pymc model just to illustrate what 'offset' is doing. BTW as far as I can determine this offset is not documented. If so where should it be documented?

@GStechschulte
Copy link
Collaborator

GStechschulte commented Sep 7, 2024

Thanks a lot for the PR! Adding the equivalent PyMC model is a good idea.

BTW as far as I can determine this offset is not documented.

You are right, it is not documented anywhere. It should probably be documented in the Getting started section of formulae (our library for formulas for mixed effects models). But as far as Bambi goes, I think having the notebook is fine for the moment.

@tomicapretto
Copy link
Collaborator

Hi @DrEntropy! Thanks a lot for going ahead and writing this example. It's great to have it in our documentation.

I have very minor stylistic comments (code formatting) but it'll be easier for me to change them in a separate PR, so I'm merging this now.

@tomicapretto tomicapretto merged commit 3ee51d6 into bambinos:main Sep 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants