Fix support for additional arguments in DefaultCommand #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @keizer619 PTAL at the changes and lmk if it's the right way to solve this issue? |
|
Hey @keizer619 any updates here? |
src/main/java/org/ballerinalang/command/cmd/DefaultCommand.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gayal Dassanayake <[email protected]>
|
|
I tested and it is working. However had an offline discussion with @keizer619 and I'm not sure if we should support |
|
Any update here? @gayaldassanayake @keizer619 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In some bal --help commands, after the help text, an error Unmatched argument at index 1: is printed
Goals
Get rid of the error that was caused due to the default command not expecting additional arguments
Approach
Add a
CommandLine.Parameterssuch that we can take in a list of parameters avoiding the error and maybe put it to use in the future instead of modify the bal shell fileUser stories
When I first found out about ballerina and started tinkering with it, I ran into this error as well, it didn't make sense to me, and neither did I think it was actually a bug, but when I found this issue, I was relieved cause I spent quite some time trying to figure out how am I typing a
--helpcommand wrong. XDRelease note
Fix unmatched argument log when running --help
Closes #309