feat: add single pool handler #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| [swapState.tokenIn.address, swapState.tokenOut.address, swapState.selectedChain] | ||
| ) | ||
| const handler = useMemo(() => { | ||
| if (isPoolSwap) resetSwapAmounts() |
There was a problem hiding this comment.
This shouldn't be here. The useMemo is about setting the swap handler and shouldn't contain other logic. If this side-effect is needed I guess it will have to go in a useEffect.
There was a problem hiding this comment.
Although, why is it needed only in the case of it being a pool swap?
| /** | ||
| * PRIVATE METHODS | ||
| */ | ||
| protected async runSimulation({ |
There was a problem hiding this comment.
Is there not a pattern for this where you don't have to rename the function to something different? Can you not call super() or something within the simulate function of the child classes to call the simulate function in the abstract class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pool swap handler and extracts an new abstract class to share common logic.
TODO: Pool swaps in nested pools do not work cause underneath pool tokens are not valid in the swap route.