Replace pysodium with libnacl #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library `pysodium` is used as "a very simple wrapper around libsodium masquerading as nacl". `libnacl` is another wrapper around the nacl library developed and maintained by the Salt project and with extensive documentation on https://libnacl.readthedocs.io and has been update to use the `pyproject.toml` format. The status of this library is marked as `5 - Production/Stable` on PyPI. The `pysodium` library has a bare bone repository with no documentation available and still uses the old 'setup.py' format. The status of this library is marked as `4 - Beta` on PyPI.
|
Hi! I like this idea! Pysodium is luckily not abandoned, but libnacl's wheels and documentation make it an attractive drop-in replacement. The only thing I worry about is a chance to break projects relying on pysodium but not adding it as a dependency explicitly. But I guess it's a pretty exotic case. |
|
Thanks for the positive feedback. Another motivation is to package pytezos (or at least the cryptography part) in Nixpkgs, which has libnacl already packaged but not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library
pysodiumis used as "a very simple wrapper around libsodium masquerading as nacl".libnaclis another wrapper around the nacl library developed and maintained by the Saltproject and with extensive documentation on https://libnacl.readthedocs.io and has been
update to use the
pyproject.tomlformat. The status of this library is marked as5 - Production/Stableon PyPI.The
pysodiumlibrary has a bare bone repository with no documentation available and still uses the old 'setup.py' format. The status of this library is marked as4 - Betaon PyPI.