Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seedless versions of .fold (aka .reduce) and .scan #743

Open
wants to merge 2 commits into
base: seedless-flatscan
Choose a base branch
from
Open

Seedless versions of .fold (aka .reduce) and .scan #743

wants to merge 2 commits into from

Conversation

semmel
Copy link
Member

@semmel semmel commented Jul 15, 2019

  • For consistency the seed value is optional in .fold and .scan too.
  • Type signature for .fold and .scan similar to the proposed signature of .flatScan.
  • Implementation of .scanSeedless is rather naive.
    • Maybe that's why I had to mark many unit tests unstable ("switching aggressively" mode did always fail - don't know why)
    • In doubt what UpdateBarrier.whenDoneWith() is, so I simply removed it for .scanSeedless
  • Duplicated most unit tests to check the seedless methods.

TODO: Update documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@semmel