Add ruby 3.3 to test matrix, update all deps, fix new cops

babbel · Jan 2, 2024 · e50374e · e50374e
1 parent 7c24e55
commit e50374e
Show file tree

Hide file tree

Showing 22 changed files with 72 additions and 65 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -22,7 +22,7 @@ jobs:
  runs-on: ubuntu-latest
  strategy:
  matrix:
- ruby: ["3.0", "3.1", "3.2"]
+ ruby: ["3.0", "3.1", "3.2", "3.3"]
  steps:
  - uses: actions/checkout@v2
 

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -12,25 +12,30 @@ PATH
 GEM
  remote: https://rubygems.org/
  specs:
- activesupport (7.0.7)
+ activesupport (7.1.2)
+ base64
+ bigdecimal
  concurrent-ruby (~> 1.0, >= 1.0.2)
+ connection_pool (>= 2.2.5)
+ drb
  i18n (>= 1.6, < 2)
  minitest (>= 5.1)
+ mutex_m
  tzinfo (~> 2.0)
  ast (2.4.2)
  async (1.31.0)
  console (~> 1.10)
  nio4r (~> 2.3)
  timers (~> 4.1)
- async-http (0.60.2)
+ async-http (0.61.0)
  async (>= 1.25)
  async-io (>= 1.28)
  async-pool (>= 0.2)
- protocol-http (~> 0.24.0)
- protocol-http1 (~> 0.15.0)
+ protocol-http (~> 0.25.0)
+ protocol-http1 (~> 0.16.0)
  protocol-http2 (~> 0.15.0)
  traces (>= 0.10.0)
- async-io (1.35.0)
+ async-io (1.38.1)
  async
  async-pool (0.4.0)
  async (>= 1.25)
@@ -44,19 +49,23 @@ GEM
  protocol-rack (~> 0.1)
  protocol-websocket (~> 0.11)
  backport (1.2.0)
- base64 (0.1.1)
- benchmark (0.2.1)
- benchmark-ips (2.12.0)
+ base64 (0.2.0)
+ benchmark (0.3.0)
+ benchmark-ips (2.13.0)
+ bigdecimal (3.1.5)
  childprocess (4.1.0)
  concurrent-ruby (1.2.2)
- console (1.23.2)
+ connection_pool (2.4.1)
+ console (1.23.3)
  fiber-annotation
  fiber-local
  dead_end (4.0.0)
  diff-lcs (1.5.0)
  docile (1.4.0)
+ drb (2.2.0)
+ ruby2_keywords
  e2mmap (0.1.0)
- factory_bot (6.2.1)
+ factory_bot (6.4.5)
  activesupport (>= 5.0.0)
  fiber-annotation (0.2.0)
  fiber-local (1.0.0)
@@ -65,49 +74,49 @@ GEM
  ibsciss-middleware (0.4.2)
  iniparse (1.5.0)
  jaro_winkler (1.5.6)
- json (2.6.3)
+ json (2.7.1)
  kramdown (2.4.0)
  rexml
  kramdown-parser-gfm (1.1.0)
  kramdown (~> 2.0)
  language_server-protocol (3.17.0.3)
  memory_profiler (1.0.1)
- mini_portile2 (2.8.4)
- minitest (5.19.0)
- nio4r (2.5.9)
- nokogiri (1.15.4)
+ mini_portile2 (2.8.5)
+ minitest (5.20.0)
+ mutex_m (0.2.0)
+ nio4r (2.7.0)
+ nokogiri (1.16.0)
  mini_portile2 (~> 2.8.2)
  racc (~> 1.4)
- nokogiri (1.15.4-x86_64-linux)
+ nokogiri (1.16.0-x86_64-linux)
  racc (~> 1.4)
  oj (3.15.1)
- overcommit (0.60.0)
+ overcommit (0.61.0)
  childprocess (>= 0.6.3, < 5)
  iniparse (~> 1.4)
  rexml (~> 3.2)
- parallel (1.23.0)
- parser (3.2.2.3)
+ parallel (1.24.0)
+ parser (3.2.2.4)
  ast (~> 2.4.1)
  racc
  protocol-hpack (1.4.2)
- protocol-http (0.24.7)
- protocol-http1 (0.15.1)
+ protocol-http (0.25.0)
+ protocol-http1 (0.16.1)
  protocol-http (~> 0.22)
  protocol-http2 (0.15.1)
  protocol-hpack (~> 1.4)
  protocol-http (~> 0.18)
- protocol-rack (0.2.6)
+ protocol-rack (0.4.1)
  protocol-http (~> 0.23)
  rack (>= 1.0)
- protocol-websocket (0.12.0)
+ protocol-websocket (0.12.1)
  protocol-http (~> 0.2)
- protocol-http1 (~> 0.2)
- racc (1.7.1)
+ racc (1.7.3)
  rack (3.0.8)
  rainbow (3.1.1)
- rake (13.0.6)
+ rake (13.1.0)
  rbs (2.8.4)
- regexp_parser (2.8.1)
+ regexp_parser (2.8.3)
  retryable (3.0.5)
  reverse_markdown (2.1.1)
  nokogiri
@@ -129,40 +138,40 @@ GEM
  diff-lcs (>= 1.2.0, < 2.0)
  rspec-support (~> 3.12.0)
  rspec-support (3.12.1)
- rubocop (1.56.0)
- base64 (~> 0.1.1)
+ rubocop (1.59.0)
  json (~> 2.3)
  language_server-protocol (>= 3.17.0)
  parallel (~> 1.10)
- parser (>= 3.2.2.3)
+ parser (>= 3.2.2.4)
  rainbow (>= 2.2.2, < 4.0)
  regexp_parser (>= 1.8, < 3.0)
  rexml (>= 3.2.5, < 4.0)
- rubocop-ast (>= 1.28.1, < 2.0)
+ rubocop-ast (>= 1.30.0, < 2.0)
  ruby-progressbar (~> 1.7)
  unicode-display_width (>= 2.4.0, < 3.0)
- rubocop-ast (1.29.0)
+ rubocop-ast (1.30.0)
  parser (>= 3.2.1.0)
- rubocop-capybara (2.18.0)
+ rubocop-capybara (2.19.0)
  rubocop (~> 1.41)
- rubocop-factory_bot (2.23.1)
- rubocop (~> 1.33)
- rubocop-performance (1.19.0)
- rubocop (>= 1.7.0, < 2.0)
- rubocop-ast (>= 0.4.0)
- rubocop-rspec (2.23.2)
+ rubocop-factory_bot (2.24.0)
  rubocop (~> 1.33)
+ rubocop-performance (1.20.1)
+ rubocop (>= 1.48.1, < 2.0)
+ rubocop-ast (>= 1.30.0, < 2.0)
+ rubocop-rspec (2.25.0)
+ rubocop (~> 1.40)
  rubocop-capybara (~> 2.17)
  rubocop-factory_bot (~> 2.22)
  ruby-prof (1.6.3)
  ruby-progressbar (1.13.0)
+ ruby2_keywords (0.0.5)
  simplecov (0.22.0)
  docile (~> 1.1)
  simplecov-html (~> 0.11)
  simplecov_json_formatter (~> 0.1)
  simplecov-html (0.12.3)
  simplecov_json_formatter (0.1.4)
- solargraph (0.49.0)
+ solargraph (0.50.0)
  backport (~> 1.2)
  benchmark
  bundler (~> 2.0)
@@ -178,15 +187,15 @@ GEM
  thor (~> 1.0)
  tilt (~> 2.0)
  yard (~> 0.9, >= 0.9.24)
- thor (1.2.2)
- tilt (2.2.0)
+ thor (1.3.0)
+ tilt (2.3.0)
  timers (4.3.5)
  traces (0.11.1)
  tzinfo (2.0.6)
  concurrent-ruby (~> 1.0)
- unicode-display_width (2.4.2)
+ unicode-display_width (2.5.0)
  yard (0.9.34)
- zeitwerk (2.6.11)
+ zeitwerk (2.6.12)
 
 PLATFORMS
  ruby

diff --git a/lib/grumlin/request_dispatcher.rb b/lib/grumlin/request_dispatcher.rb
@@ -61,7 +61,7 @@ def ongoing_request?(request_id)
  end
 
  def clear
- @requests.each do |_id, request|
+ @requests.each_value do |request|
  request[:channel].close!
  end
  @requests.clear

diff --git a/spec/async/channel_spec.rb b/spec/async/channel_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Async::Channel, async: true do
+RSpec.describe Async::Channel, :async do
  let(:channel) { described_class.new }
 
  describe "#<<" do

diff --git a/spec/factories/edge_factory.rb b/spec/factories/edge_factory.rb
@@ -5,7 +5,6 @@
  initialize_with { new(**attributes) }
 
  label { "test_edge" }
- sequence(:id)
  inVLabel { "test_vertex" }
  outVLabel { "test_vertex" }
  sequence(:inV)

diff --git a/spec/factories/vertex_factory.rb b/spec/factories/vertex_factory.rb
@@ -5,6 +5,5 @@
  initialize_with { new(**attributes) }
 
  label { "test_vertex" }
- sequence(:id)
  end
 end
diff --git a/spec/grumlin/dummy_transaction_spec.rb b/spec/grumlin/dummy_transaction_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::DummyTransaction, gremlin_server: true do
+RSpec.describe Grumlin::DummyTransaction, :gremlin_server do
  let(:tx) { g.tx }
 
  describe "defaults" do

diff --git a/spec/grumlin/practical_gremlin/0_import_data_spec.rb b/spec/grumlin/practical_gremlin/0_import_data_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe "Practical Gremlin: Import data", gremlin_server: true, timeout: 60 do
+RSpec.describe "Practical Gremlin: Import data", :gremlin_server, timeout: 60 do
  let(:graphml) { File.read("spec/fixtures/air_routes/air-routes.graphml") }
  let(:importer) { GraphMLImporter.new(graphml) }
 

diff --git a/spec/grumlin/query_validators/blocklisted_steps_validator_spec.rb b/spec/grumlin/query_validators/blocklisted_steps_validator_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::QueryValidators::BlocklistedStepsValidator, gremlin: true do
+RSpec.describe Grumlin::QueryValidators::BlocklistedStepsValidator, :gremlin do
  let(:validator) { described_class.new(:addV, :drop) }
 
  shared_examples "considers query valid" do

diff --git a/spec/grumlin/repository/instance_methods_spec.rb b/spec/grumlin/repository/instance_methods_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::Repository::InstanceMethods, gremlin_server: true do
+RSpec.describe Grumlin::Repository::InstanceMethods, :gremlin_server do
  let(:repository_class) do
  Class.new do
  extend Grumlin::Repository

diff --git a/spec/grumlin/repository_spec.rb b/spec/grumlin/repository_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::Repository, gremlin_server: true do
+RSpec.describe Grumlin::Repository, :gremlin_server do
  let(:repository_class) do
  Class.new do
  extend Grumlin::Repository

diff --git a/spec/grumlin/request_dispatcher_spec.rb b/spec/grumlin/request_dispatcher_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::RequestDispatcher, async: true do
+RSpec.describe Grumlin::RequestDispatcher, :async do
  let(:dispatcher) { described_class.new }
 
  describe "#add_request" do

diff --git a/spec/grumlin/shortcuts_applyer_spec.rb b/spec/grumlin/shortcuts_applyer_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::ShortcutsApplyer, gremlin: true do
+RSpec.describe Grumlin::ShortcutsApplyer, :gremlin do
  describe ".call" do
  subject { described_class.call(steps) }
 

diff --git a/spec/grumlin/steps_serializers/bytecode_spec.rb b/spec/grumlin/steps_serializers/bytecode_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::StepsSerializers::Bytecode, gremlin: true do
+RSpec.describe Grumlin::StepsSerializers::Bytecode, :gremlin do
  let(:serializer) { described_class.new(steps) }
 
  # TODO: add cases with predicates

diff --git a/spec/grumlin/steps_serializers/human_readable_bytecode_spec.rb b/spec/grumlin/steps_serializers/human_readable_bytecode_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::StepsSerializers::HumanReadableBytecode, gremlin: true do
+RSpec.describe Grumlin::StepsSerializers::HumanReadableBytecode, :gremlin do
  let(:serializer) { described_class.new(steps) }
 
  # TODO: add cases with predicates

diff --git a/spec/grumlin/steps_serializers/string_spec.rb b/spec/grumlin/steps_serializers/string_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::StepsSerializers::String, gremlin: true do
+RSpec.describe Grumlin::StepsSerializers::String, :gremlin do
  let(:serializer) { described_class.new(steps, apply_shortcuts: apply_shortcuts) }
 
  let(:shortcuts) do

diff --git a/spec/grumlin/steps_spec.rb b/spec/grumlin/steps_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::Steps, gremlin: true do
+RSpec.describe Grumlin::Steps, :gremlin do
  let(:steps) { described_class.new(shortcuts) }
 
  describe ".from" do

diff --git a/spec/grumlin/stress_spec.rb b/spec/grumlin/stress_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe "stress test", gremlin_server: true, timeout: 120 do
+RSpec.describe "stress test", :gremlin_server, timeout: 120 do
  let(:uuids) { Array.new(1000) { SecureRandom.uuid } }
  let(:upsert_uuids) { Array.new(5) { SecureRandom.uuid } }
 

diff --git a/spec/grumlin/transaction_spec.rb b/spec/grumlin/transaction_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::Transaction, gremlin_server: true do
+RSpec.describe Grumlin::Transaction, :gremlin_server do
  let(:tx) { g.tx }
 
  before do

diff --git a/spec/grumlin/transport_spec.rb b/spec/grumlin/transport_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::Transport, gremlin_server: true do
+RSpec.describe Grumlin::Transport, :gremlin_server do
  let!(:transport) { described_class.new(Grumlin.config.url) }
 
  describe "when Async::WebSocket::Client#connect is not used" do

diff --git a/spec/grumlin/traversal_start_spec.rb b/spec/grumlin/traversal_start_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::TraversalStart, gremlin_server: true do
+RSpec.describe Grumlin::TraversalStart, :gremlin_server do
  describe "#tx" do
  subject { g.tx }
 

diff --git a/spec/grumlin/with_extension_spec.rb b/spec/grumlin/with_extension_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Grumlin::WithExtension, gremlin: true do
+RSpec.describe Grumlin::WithExtension, :gremlin do
  let(:shortcuts) { Grumlin::Shortcuts::Storage.new }
 
  let(:klass) do