-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Config/Code): Correct typo #31
Conversation
conf/my_custom.conf.dist
Outdated
@@ -14,4 +14,4 @@ | |||
# 1 - Enabled | |||
# | |||
|
|||
MyModule.Enable = 1 | |||
MyModule.Enable = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put it as 1 by default, because the developer that will use this, will surely set it as 1 to work on it
Add default value to 1, so that it is enabled. On the contrary, the message will not be displayed on the screen otherwise.
I agree with Helias, it is better to leave it at 1, so that the message is displayed. As for the typo error, it was probably my fault. Thanks for correcting it. |
thanks for the PR! |
Yeah fair enough, I was mostly annoyed by the typo every time I created by a new module I had to fix it. 😄 |
That probably happened when I did the part of adding the translations to the DB. Create the enum, and obviously, I misspelled it and I forgot. As generally, that part is usually deleted, to create the new module, it happened over time. But thanks for correcting it. |
Changes Proposed:
Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes: