Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Config/Code): Correct typo #31

Merged
merged 2 commits into from
Feb 16, 2024
Merged

fix(Config/Code): Correct typo #31

merged 2 commits into from
Feb 16, 2024

Conversation

AnchyDev
Copy link
Contributor

Changes Proposed:

  • Fix a typo with the MyPlayerAcoreString enum.
  • Set the default module enable config to 0 (the description states the default is 0).

Issues Addressed:

  • N/A

SOURCE:

  • N/A

Tests Performed:

  • Tested the module still works as expected.

How to Test the Changes:

  1. Enable the module in the config.
  2. Start server.
  3. Login to a character.
  4. Observe there is a system message sent from the module.

@@ -14,4 +14,4 @@
# 1 - Enabled
#

MyModule.Enable = 1
MyModule.Enable = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put it as 1 by default, because the developer that will use this, will surely set it as 1 to work on it

Add default value to 1, so that it is enabled. On the contrary, the message will not be displayed on the screen otherwise.
@pangolp
Copy link
Contributor

pangolp commented Feb 16, 2024

I agree with Helias, it is better to leave it at 1, so that the message is displayed. As for the typo error, it was probably my fault. Thanks for correcting it.

@pangolp pangolp changed the title fix(Config/Code): Correct typo and set default config enable to 0. fix(Config/Code): Correct typo Feb 16, 2024
@Helias Helias merged commit 39410bb into azerothcore:master Feb 16, 2024
2 checks passed
@Helias
Copy link
Member

Helias commented Feb 16, 2024

thanks for the PR!

@AnchyDev
Copy link
Contributor Author

I agree with Helias, it is better to leave it at 1, so that the message is displayed. As for the typo error, it was probably my fault. Thanks for correcting it.

Yeah fair enough, I was mostly annoyed by the typo every time I created by a new module I had to fix it. 😄

@pangolp
Copy link
Contributor

pangolp commented Feb 16, 2024

I agree with Helias, it is better to leave it at 1, so that the message is displayed. As for the typo error, it was probably my fault. Thanks for correcting it.

Yeah fair enough, I was mostly annoyed by the typo every time I created by a new module I had to fix it. 😄

That probably happened when I did the part of adding the translations to the DB. Create the enum, and obviously, I misspelled it and I forgot. As generally, that part is usually deleted, to create the new module, it happened over time. But thanks for correcting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants