fix(SAI): update queries on comment generation [beta 1] (#376)

azerothcore · Feb 6, 2020 · 65b8e40 · 65b8e40
1 parent 0143d2b
commit 65b8e40
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/app/shared/modules/sai-editor/sai-editor.component.integration.spec.ts b/src/app/shared/modules/sai-editor/sai-editor.component.integration.spec.ts
@@ -269,6 +269,10 @@ describe('SaiEditorComponent integration tests', () => {
         .toEqual(`${name} - On Just Died - Start Attacking`);
       expect(page.getDatatableCell(page.EDITOR_DT_SELECTOR, 2, saiColIndex).innerText)
         .toEqual(`${name} - On Evade - Flee For Assist`);
+
+      page.expectAllQueriesToContain(`${name} - On Aggro - Kill Target`);
+      page.expectAllQueriesToContain(`${name} - On Just Died - Start Attacking`);
+      page.expectAllQueriesToContain(`${name} - On Evade - Flee For Assist`);
     });
   });
 

diff --git a/src/app/shared/modules/sai-editor/sai-editor.service.ts b/src/app/shared/modules/sai-editor/sai-editor.service.ts
@@ -110,6 +110,9 @@ export class SaiEditorService extends MultiRowComplexKeyEditorService<SmartScrip
         this._form.controls.comment.setValue(row.comment);
       }
     }
+
+    this.updateDiffQuery();
+    this.updateFullQuery();
     this.refreshDatatable();
   }
 }
diff --git a/src/app/shared/testing/editor-page-object.ts b/src/app/shared/testing/editor-page-object.ts
@@ -126,6 +126,11 @@ export abstract class EditorPageObject<T> extends PageObject<T> {
     expect(this.queryPo.diffQueryWrapper.innerText).toContain(expectedQuery);
   }
 
+  expectAllQueriesToContain(expectedQuery: string) {
+    this.expectDiffQueryToContain(expectedQuery);
+    this.expectFullQueryToContain(expectedQuery);
+  }
+
   expectFullQueryToBeEmpty() {
     expect(this.queryPo.fullQueryWrapper.innerText).toEqual('');
   }