Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema.org Metatag "CollegeOrUniversity" issue/3644 #3743

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

mrbeiley
Copy link
Contributor

Description

Resolves #3644, adding a new module to the existing Schema.org Metatag modules. This module contains all the fields laid out in this document.

Release notes

If this change requires release notes: provide a summary of changes, how to
use this change, and any related links. This content will be pasted in the
release notes. Use
markdown format to ensure proper pasting of information.

Make sure to add the release notes label to this PR.

Add markdown of release notes here.

Related issues

#3644

How to test

(on local, lando site)

  • Install the 'Schema Metatag CollegeOrUniversity Final' module
  • Open up a Page in the CKeditor
  • Click the 'Metatags' dropdown
  • Find the 'CollegeOrUniversity' dropdown
  • Enter in sample fields and save the Page
  • View the page and open the source code
  • The Schema data should be displayed inside the "<script type=application/ld+json"> tag
  • Verify Schema structure and data

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@mrbeiley mrbeiley requested a review from a team as a code owner September 26, 2024 18:38
@mrbeiley mrbeiley linked an issue Sep 26, 2024 that may be closed by this pull request
@joshuasosa
Copy link
Contributor

Seems interesting but I was unable to test on the Probo site. The Schema.org CollegeOrUniversity Final module says "Requires: schema_metatag (missing)." Does schema_metatag need to be added as something that'll come packaged with AZQS or is it expected to need to include it in custom composer?

Besides that, it looks like this PR is adding a custom module. Other custom modules have a prefix of 'az_', which makes me think this one should similarly have that prefix.

@mrbeiley
Copy link
Contributor Author

Seems interesting but I was unable to test on the Probo site. The Schema.org CollegeOrUniversity Final module says "Requires: schema_metatag (missing)." Does schema_metatag need to be added as something that'll come packaged with AZQS or is it expected to need to include it in custom composer?

Besides that, it looks like this PR is adding a custom module. Other custom modules have a prefix of 'az_', which makes me think this one should similarly have that prefix.

Yes it should have the 'az_' prefix, probably. As for the schema_metatag module, I don't know...

@mrbeiley
Copy link
Contributor Author

  • Create an Issue to add the module to Schema.org Metatag. Are they interested in including this? Give at least a couple weeks to discuss it. Joe can help.
  • Add 'az_' prefix to module
  • Possibly add 'CollegeOrUniversity' Property type

@mrbeiley mrbeiley added enhancement New feature or request Drupal Waiting on a fix from the Drupal community labels Sep 27, 2024
@joshuasosa
Copy link
Contributor

Someone can correct me but I think you'd need to add schema_metatag to the composer file for this to be reviewable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal Waiting on a fix from the Drupal community enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema.org Metatag "CollegeOrUniversity"
4 participants