-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update drupal/environment_indicator requirement from 4.0.10 to 4.0.19 #3457
base: main
Are you sure you want to change the base?
Update drupal/environment_indicator requirement from 4.0.10 to 4.0.19 #3457
Conversation
Updates the requirements on drupal/environment_indicator to permit the latest version. --- updated-dependencies: - dependency-name: drupal/environment_indicator dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Looks like the issue introduced in 4.0.11 that has prevented us from upgrading this module is still not fixed as of this new release (😞) but we're falling pretty far behind now so we may want to look into patches or other workarounds for that problem. |
See az-digital/az_quickstart#3457 Removes `(Pantheon)` from environment indicator names since the latest versions of the module prepend the name with either a deployment identifier or version number in parentheses.
I added a config file to this PR branch that should effectively disable the deployment indicator/version from being displayed which would maintain our current environment indicator behavior (at least on Pantheon). The more I think about this, though, I think I've realized that my biggest gripe with the module changes is that it prepends the deployment identifier or version number (in parentheses) to the environment name that we configure per-environment on Pantheon that also includes parentheses. So our existing I've created a PR for the Pantheon upstream that removes the |
@trackleft please feel free to revert/remove the config file I added to this PR. |
We are blocked by https://www.drupal.org/project/environment_indicator/issues/3324621 |
A newer version of drupal/environment_indicator exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Updates the requirements on drupal/environment_indicator to permit the latest version.
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)