Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #1273 Closes #3848: Allow multiple select menus on the same page #1387

Open
wants to merge 81 commits into
base: main
Choose a base branch
from
Open

Closes #1273 Closes #3848: Allow multiple select menus on the same page #1387

wants to merge 81 commits into from
+15 −9

Conversation

RyanDool
Copy link

@RyanDool RyanDool commented Mar 8, 2022 •
edited by danahertzberg
Loading

Description

This change makes unique IDs for each select element and adds a reference to that unique ID in the associated label element.

Related Issues

Closes #1273
Closes #3848

How to test

  1. Enable the Quickstart select menu module
  2. Add two new "select menu" blocks on the same page
  3. Operate each block independently
  4. Inspect to observe 'for' element on the label and 'id' on the select are the same

Previous reference

See https://user-images.githubusercontent.com/1023167/169171863-e881d394-b837-46d6-9494-bf07c16b4419.mov

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@RyanDool RyanDool linked an issue Mar 8, 2022 that may be closed by this pull request
Change AZ Select Menu JS to support more than one instance or explicitly indicate that only one instance is supported. #1273
Open
smayden and others added 25 commits May 18, 2022 14:26
@smayden @danahertzberg @trackleft
Closes #1331: Make sidebar not overlap text for Text with Background (#…
98610f4 
…1360)

Co-authored-by: Dana Hertzberg <[email protected]>
@joeparsons @trackleft
Closes #1350: Implement more flexible update hook numbering scheme. (#…
9bfaeca 
…1351)
@joeparsons @trackleft
Jan 2022 Consolidated contrib module updates. (#1258)
8819535
@kevcooper @michaelhagedon
@joeparsons @trackleft
Closes #1333: Configure system mail interface to use SMTP during inst…
81a521d 
…all. (#1334)

Co-authored-by: Michael Hagedon <[email protected]>
Co-authored-by: Joe Parsons <[email protected]>
@joeparsons @trackleft
Closes #1317: Add update hook to delete problematic legacy global foo…
d9605b5 
…ter menu blocks. (#1332)
@joeparsons @trackleft
Closes #1371: Add az prefix to EntityEmbedProcess migrate plugin ID. (#…
bee804a 
…1372)
@trackleft @joeparsons @danahertzberg
Closes #892: Reduce paragraphs behavior settings migrate plugin compl…
9ebd5be 
…exity (#1345)

Co-authored-by: Joe Parsons <[email protected]>
Co-authored-by: Dana Hertzberg <[email protected]>
@joeparsons @trackleft
#1367: Update composer branch alias for dev-main to 2.3.x-dev (#1377)
4454682
@joeparsons @trackleft
Fixes #1385, Fixes #1386: Add patch for media_migation module issue b…
358762d 
…reaking az_global_footer install on migrated sites. (#1391)

* Fixes #1385: Add patch for media_migation module issue breaking az_global_footer install on migrated sites.
@trackleft @joeparsons
Fixes #1384 Global Footer (after 2.2 Update) Formatting Incorrect (#1393
eb1e0ae 
)

Co-authored-by: Joe Parsons <[email protected]>
@bberndt-uaz @trackleft
Closes #1390 by setting maxlength of Card Link URL field to 2048 char…
a305ec3 
…acters (#1392)
@trackleft @michaelhagedon
Fixes #1356 Adding z-index for rendering full-width backgrounds behin…
301100b 
…d sidebars (#1365)

Co-authored-by: Mike Hagedon <[email protected]>
@joeparsons @trackleft
Fixes #1401: Update Drupal core to 9.2.15 for SA-CORE-2022-005. (#1402)
d7e8078
@trackleft
Fixes #1397 Update migrations to add text_media_spacing default and c…
266dc89 
…hange bg_attach to bg_attachment (#1398)
@joeparsons @trackleft
Closes #876: Enable testing of related az-quickstart-dev branches in …
0a1779f 
…main repo CI builds. (#877)
@joeparsons @trackleft
Fixes #1415: Add required default_theme property to all tests. (#1417)
600aeb1
@joeparsons @trackleft
Closes #1421: Update Drupal core to 9.2.16 for SA-CORE-2022-006. (#1422)
dcb3f86
@kevcooper @trackleft
Closes #595: Add az_security module (#915)
05ebc1f
@kevcooper @trackleft
Closes #1311: Default XDebug config for VS Code (#1312)
006cdae 
Co-authored-by: Chris Green <[email protected]>
@cpoff @trackleft
Closes #396 Updated CKEditor icons for embed buttons (#1423)
d18d8e7
@trackleft
Fixes #1232 Optionally add html paragraphs to migration lookup, and r…
fc6800f 
…emove contacts from page migration. (#1416)
@trackleft @bberndt-uaz @joeparsons
Update Quickstart Migration README for developer workshop. (#1437)
bd30a75 
Co-authored-by: bberndt-uaz <[email protected]>
Co-authored-by: Joe Parsons <[email protected]>
@trackleft @joeparsons
Closes #1231: Migrate front page (#1411)
52a0518 
Co-authored-by: Joe Parsons <[email protected]>
@trackleft
Closes #1133 Adding required markup for subhead and moving to the top…
b0e3004 
… of flexible page migration. (#1419)
@trackleft @joeparsons
Fixes #1438: Add patch for AP Style Date module time display issue (#…
0fe4271 
…1442)

Co-authored-by: Joe Parsons <[email protected]>
@trackleft trackleft changed the title assign array and key value intstead of empty array Closes #1273 Allow multiple select menus on the same page. May 18, 2022
@trackleft
Copy link
Member

trackleft commented May 23, 2022 •
edited
Loading

This resolves the issue as it stands, but we should look through it to remove any unneeded code for the fix to work. or decide whether to use data attribute or an ID, but not both.

Best practice would probably be to use the data attributes for this, since ID's tend to change with big pipe/caching/lazy loading of blocks.

@joeparsons joeparsons added needs discussion Further discussion required to determine requirements bug Something isn't working enhancement New feature or request labels Aug 2, 2023
@joeparsons joeparsons marked this pull request as ready for review August 4, 2023 17:57
@joeparsons joeparsons requested a review from a team as a code owner August 4, 2023 17:57
@joeparsons joeparsons removed the needs discussion Further discussion required to determine requirements label Aug 4, 2023
@danahertzberg
Copy link
Contributor

@RyanDool Looks like there was some review on this one if you could take a look again, please. Thanks!

@danahertzberg
Copy link
Contributor

Consider adding this issue into this PR as well
#3848

@danahertzberg danahertzberg changed the title Closes #1273 Allow multiple select menus on the same page. Closes #1273 Closes #3848: Allow multiple select menus on the same page Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeparsons joeparsons joeparsons left review comments

@trackleft trackleft trackleft left review comments

@danahertzberg danahertzberg danahertzberg left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@RyanDool RyanDool

Labels
accessibility bug Something isn't working enhancement New feature or request
Projects
2.12.1
Status: Needs review
Milestone
No milestone