Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(axelarnet): archive failed transfer #2200

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

haiyizxx
Copy link
Contributor

@haiyizxx haiyizxx commented Oct 21, 2024

Description

AXE-5726

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@haiyizxx haiyizxx marked this pull request as ready for review October 21, 2024 20:51
@haiyizxx haiyizxx requested a review from a team as a code owner October 21, 2024 20:51
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 12 lines in your changes missing coverage. Please review.

Project coverage is 39.27%. Comparing base (fe8587a) to head (b4d2b7e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/axelarnet/keeper/msg_server.go 78.26% 4 Missing and 1 partial ⚠️
x/nexus/keeper/transfer.go 0.00% 5 Missing ⚠️
x/axelarnet/types/mock/expected_keepers.go 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
+ Coverage   39.19%   39.27%   +0.07%     
==========================================
  Files         373      373              
  Lines       37241    37276      +35     
==========================================
+ Hits        14598    14641      +43     
+ Misses      21709    21700       -9     
- Partials      934      935       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy
Copy link
Contributor

How does retry work if failed transfers are now archived?

x/axelarnet/keeper/msg_server.go Outdated Show resolved Hide resolved
x/axelarnet/keeper/msg_server.go Show resolved Hide resolved
@haiyizxx haiyizxx merged commit 31dd11d into main Oct 30, 2024
6 of 7 checks passed
@haiyizxx haiyizxx deleted the run-cache-context branch October 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants