feat(nexus): gmp events metadata #2187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiyizxx
force-pushed
the
AXE-5194-core-GMP-metadata-events
branch
from
359710c
to
2180024
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2187 +/- ##
==========================================
- Coverage 49.42% 39.84% -9.59%
==========================================
Files 272 373 +101
Lines 16151 30868 +14717
==========================================
+ Hits 7983 12299 +4316
- Misses 7557 17645 +10088
- Partials 611 924 +313 ☔ View full report in Codecov by Sentry. |
milapsheth
reviewed
Sep 27, 2024
haiyizxx
force-pushed
the
AXE-5194-core-GMP-metadata-events
branch
from
5cfba64
to
9a8db9e
Compare
haiyizxx
force-pushed
the
AXE-5194-core-GMP-metadata-events
branch
from
e856a60
to
04cf91f
Compare
milapsheth
approved these changes
Sep 30, 2024
milapsheth
reviewed
Sep 30, 2024
| @@ -57,9 +57,25 @@ message MessageReceived { | |||
|
|
|||
| message MessageProcessing { string id = 1 [ (gogoproto.customname) = "ID" ]; } | |||
There was a problem hiding this comment.
what about this one? Let's add it here for consistency as well. I think axelarscan might have requested this at some point as well
There was a problem hiding this comment.
can add, they didn't ask for this
cjcobb23
reviewed
Sep 30, 2024
| if fee == nil { | ||
| return token, nil | ||
| } | ||
|
|
||
| feeAmount := funcs.MustOk(sdk.NewIntFromString(fee.Amount)) | ||
| coin := sdk.NewCoin(funcs.Must(token.GetOriginalDenom()), feeAmount) | ||
| recipient := funcs.Must(sdk.AccAddressFromBech32(fee.Recipient)) | ||
| destinationChain = nexus.ChainName(strings.ToLower(destinationChain.String())) |
There was a problem hiding this comment.
why is this necessary? It's the same type. Is this about casing? If so, can you add a comment?
cjcobb23
approved these changes
Sep 30, 2024
|
close in favour of #2187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes