chore: makefile should use latest release of golangci-lint #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack0son
requested review from
cgorenflo,
jcs47,
haiyizxx,
fish-sammy,
milapsheth and
cjcobb23
as code owners
milapsheth
approved these changes
Aug 11, 2023
|
|
|
Do we want latest, or do we want to pin to a specific version? |
since it's a linter, i'd prefer to use the latest |
|
looks like the latest golangci-lint release requires go 1.20. pinned the older version instead. couldn't use the tools.go since the golangci-lint cmd doesn't have a go.mod |
cgorenflo
approved these changes
Aug 28, 2023
|
+1 @jack0son |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran in to this issue installing golangci-lint from source. Turns installing from source has a few known issues detailed here.
Specifically:
it allows installation from master branch which can't be considered stable.Running
go install github.com/golangci/golangci-lint/cmd/golangci-lintcaused issues with go.sum (likely because go.mod doesn't specify a version of golangci-lint. Fixed it by runninginstall github.com/golangci/golangci-lint/cmd/golangci-lint@latestsolution
If we install golangci-lint from source we should either:
a. use a release version in the makefile
b. add golangci-lint to go.mod
Unsure which is appropriate - up to you guys. Just wanted to flag this in case anyone external runs into this issue.