feat(gateway): add instance ttl extension #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add ttl extension for instance storage when validate_proof is called
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 28 28
Lines 2983 2990 +7
=======================================
+ Hits 2967 2974 +7
Misses 16 16 ☔ View full report in Codecov by Sentry. |
milapsheth
reviewed
Oct 31, 2024
ahramy
reviewed
Oct 31, 2024
- encapsulate instance extend ttl logic in a public function - move call of extend_instance_ttl to approve_messages, the most commonly used entrypoint - change const variables defining ttl extension params for clarity - add comment explaining ttl extension reasoning
ahramy
reviewed
Oct 31, 2024
ahramy
reviewed
Oct 31, 2024
ahramy
reviewed
Oct 31, 2024
- remove pub visibility on extend_instance_ttl()
- remove space after /// to fix linting error
- increase instance ttl extend threshold to 14 days
milapsheth
approved these changes
Nov 3, 2024
ahramy
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-6098