Support QNX OS platform #1788
Merged
Support QNX OS platform #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axboe
reviewed
Jul 12, 2024
axboe
reviewed
Jul 12, 2024
axboe
reviewed
Jul 12, 2024
|
Minor comments posted, but this looks much better than the earlier mess :-) |
|
Thanks for your review. i updated the changes |
axboe
reviewed
Jul 12, 2024
axboe
reviewed
Jul 12, 2024
axboe
reviewed
Jul 12, 2024
axboe
reviewed
Jul 12, 2024
oslib/inet_aton.h
Outdated
| @@ -2,6 +2,9 @@ | |||
| #define FIO_INET_ATON_LIB_H | |||
|
|
|||
| #include <arpa/inet.h> | |||
| #if defined(__QNX__) | |||
There was a problem hiding this comment.
you are right, No, it is not need.
|
Thanks, added a few more comments on items I missed the first time around. |
Compile command: QNX SDP7.1 example ./configure --cc=aarch64-unknown-nto-qnx7.1.0-gcc --disable-shm make Function is verified by UFS device read and write test. Signed-off-by: Huang weiliang <[email protected]>
|
Thanks for your patience :) |
|
Merged, and added a fix for a bug on top. |
|
Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support QNX OS platform
To mainline those changes for better maintenance.
Compile command: QNX SDP7.1 example
./configure --cc=aarch64-unknown-nto-qnx7.1.0-gcc --disable-shm; make
Basic file read and write test with ioengine=sync is verified.
Signed-off-by: Huang weiliang [email protected]