Add some comments and deduplicate or simplify logic #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oli-obk hey there! thanks for the PR and im happy with continuing to merge any improvements to the main branch, but this branch is to be deprecated, to see the current code, check out the webxr-refactor branch, which is a much higher quality refactor that will allow us to implement webxr easily in the future without changing the user facing api. that branch contains the crates that we plan on merging into the main bevy engine. |
|
gotcha, thanks! will look at that branch then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some stuff I noticed while trying to understand how it all works