Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions #298

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Update Github actions #298

merged 5 commits into from
Nov 15, 2024

Conversation

hughcars
Copy link
Collaborator

In some macos github action builds:

[build-and-test-macos (gcc, openmpi, openblas, static, int64, openmp, superlu, arpack)](https://github.com/awslabs/palace/actions/runs/11825573260/job/32994205616#step:4:17)
You are using macOS 12.
We (and Apple) do not provide support for this old version.
It is expected behaviour that some formulae will fail to build in this old version.
It is expected behaviour that Homebrew will be buggy and slow.
Do not create any issues about this on Homebrew's GitHub repositories.
Do not create any issues even if you think this message is unrelated.
Any opened issues will be immediately closed without response.
Do not ask for help from Homebrew or its maintainers on social media.
You may ask for help in Homebrew's discussions but are unlikely to receive a response.
Try to figure out the problem yourself and submit a fix as a pull request.
We will review it but may or may not accept it.

Looks like the github action runners macos-latest-xl might've been moved to macos-latest-large. Should probably add an m1 build to the CI.

@hughcars hughcars force-pushed the hughcars/macos-github-runner-update branch 3 times, most recently from 11bf5ba to f7ac3a2 Compare November 14, 2024 21:45
@hughcars hughcars force-pushed the hughcars/macos-github-runner-update branch from f7ac3a2 to b888d6d Compare November 14, 2024 21:54
@hughcars hughcars force-pushed the hughcars/macos-github-runner-update branch from 12e97ce to f5a8756 Compare November 14, 2024 22:12
…uild. Also fix printing message for BLAS discovery
@hughcars hughcars marked this pull request as ready for review November 15, 2024 17:53
Copy link
Collaborator

@phdum-a phdum-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Couple of minor suggestions but these are optional.

else()
message(STATUS "Using BLAS/LAPACK located by CMake")
endif()

list(APPEND CMAKE_PREFIX_PATH ${OPENBLAS_DIR})
Copy link
Collaborator

@phdum-a phdum-a Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line (new 175) might be better in the if clause above, although it does nothing if empty.

set(BLA_VENDOR "OpenBLAS")
message(STATUS "Using BLAS/LAPACK from OpenBLAS")
else()
message(STATUS "Using BLAS/LAPACK located by CMake")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok — for this to trigger we need to not have defined the root paths (ARMPL|AOCL|MKL|OPENBLAS)(_DIR|ROOT|_ROOT). Then it will just call the default find lapack which will look for BLA_VENDOR.

The one question I had — do we want to treat the case specially where BLA_VENDOR is already set at the beginning of the script? Right now BLA_VENDOR is ignored or overwritten without warning/error, if even one of the root paths above is set. (e.g. if ARMPL_DIR is set in the environment and I set BLA_VENDOR=OpenBLAS I will not get OpenBLAS).

Copy link
Collaborator Author

@hughcars hughcars Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this probably worth handling, but I'll do in a follow up PR (#299), as doing it neatly is going to involve a modest amount of refactoring in this file (in particular handling the AOCL section) and then a significant amount of testing for the edges.

@@ -84,7 +88,7 @@ jobs:
export FC=gfortran-12
fi
if [[ "${{ matrix.math-libs }}" == 'openblas' ]]; then
export OPENBLAS_DIR=/usr/local/opt/openblas
export OPENBLAS_DIR=/opt/homebrew/opt/openblas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but might suggest export OPENBLAS_DIR=$(brew --prefix openblas) for consistency with llvm on line 78.

@@ -53,6 +53,10 @@ jobs:
run: |
brew install pkg-config

- uses: julia-actions/setup-julia@v2
with:
version: '1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a recommendation from julia whether to also pin subversion (1.10 / 1.11)? I know these can have some breaking changes, although our usage might be light enough not to worry.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather let it run along at 1 until there's a bug to prevent us otherwise. That way we'll naturally incorporate any updates. Our usage is very light anyway, so should be fine I think.

@hughcars hughcars merged commit 6c64ad7 into main Nov 15, 2024
17 checks passed
@hughcars hughcars deleted the hughcars/macos-github-runner-update branch November 15, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants